Closed Bug 926471 Opened 11 years ago Closed 11 years ago

Replace className comparisons with classList.contains in videocontrols.xml

Categories

(Toolkit :: Video/Audio Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jaws, Assigned: soumyakanti.chakraborty)

Details

(Whiteboard: [good first bug][mentor=jaws][lang=js])

Attachments

(1 file)

See the following search for each instance of this: http://mxr.mozilla.org/mozilla-central/search?string=.className+%3D%3D&find=videocontrols.xml&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

If someone adds a new className to the element, these checks will fail. They should instead be using .classList.contains().
I would like to work on this bug.
Hi Soumya, let me know if you have any questions while you work on this bug.
Assignee: nobody → soumyakanti.chakraborty
Status: NEW → ASSIGNED
The other bugs which are cloned from this, also needs the className to be replaced by .classList.contains(). Should that also be taken care in this one ? 

Or should I nominate myself for those too ?
Please keep them separate. It would be best if you just take one and leave the others for other new contributors. After you get your first bug fixed, there will be other bugs that have a higher degree of difficulty.
Replaced className comparisons with classList.contains in videocontrols.xml
Attachment #818103 - Flags: review?(jaws)
Comment on attachment 818103 [details] [diff] [review]
Replace className comparisons with classList.contains in videocontrols.xml.patch

Review of attachment 818103 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! Thanks for the patch :-)
Attachment #818103 - Flags: review?(jaws) → review+
https://hg.mozilla.org/integration/fx-team/rev/1de0620d8ab9
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=jaws][lang=js] → [good first bug][mentor=jaws][lang=js][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/1de0620d8ab9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=jaws][lang=js][fixed-in-fx-team] → [good first bug][mentor=jaws][lang=js]
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: