926544 - subprocess crash during content/base/test/test_bug578096.html on debug B2G emulators

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

The test content/base/test/test_bug578096.html is failing on debug B2G emulators - it causes a child process to crash when started:

12:11:05     INFO -  10-11 19:08:56.950   709   709 I GeckoDump: 28252 INFO TEST-START | /tests/content/base/test/test_bug578096.html
12:11:05     INFO -  10-11 19:09:00.960   709   709 I Gecko   : [Child 709] WARNING: This file has not been opened (or could not be opened). Sending an invalid file descriptor to the other process!: file ../../../../gecko/netwerk/base/src/nsFileStreams.cpp, line 557
12:11:05     INFO -  10-11 19:09:00.980   667   667 I Gecko   : IPDL protocol error: [PNeckoParent] Received an invalid file descriptor!
12:11:05     INFO -  10-11 19:09:00.980   667   667 I Gecko   : [Parent 667] WARNING: Received an invalid file descriptor!: 'fd.IsValid()', file ../../../../gecko/netwerk/base/src/nsFileStreams.cpp, line 596
12:11:05     INFO -  10-11 19:09:01.000   667   667 F MOZ_Assert: Assertion failure: mHandleCreatedByOtherProcessWasUsed, at ../../../gecko/ipc/glue/FileDescriptor.cpp:69
12:11:05     INFO -  10-11 19:09:04.280    33    33 I ServiceManager: service 'media.resource_manager' died
12:11:05     INFO -  10-11 19:09:04.290   709   709 I Gecko   :
12:11:05     INFO -  10-11 19:09:04.290   709   709 I Gecko   : ###!!! [Child][MessageChannel] Error: Channel error: cannot send/recv
12:11:05     INFO -  10-11 19:09:04.290   709   709 I Gecko   :
12:11:05     INFO -  10-11 19:09:04.290   709   709 I Gecko   : [Child 709] WARNING: content process _exit()ing: file ../../../gecko/dom/ipc/ContentChild.cpp, line 1098

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=28998639&tree=Cedar&full=1#error8

Comment 1

[Josh Matthews [:jdm]]

Benjamin, do you know if we have access to TmpD in content processes? http://mxr.mozilla.org/mozilla-central/source/content/base/test/test_bug578096.html?force=1#25

Comment 2

[Martijn Wargers (dead)]

I looked at this test, when I add a dump for the file.path, I get /data/local/tmp/foo.txt back, so it does seem to work (this was in a non-debug emulator, fwiw).
I don't know how this works though, because TmpD doesn't exist in DirectoryProvider.js:
http://mxr.mozilla.org/mozilla-central/source/b2g/components/DirectoryProvider.js#47

Perhaps, this is related to bug 902271 (and somehow doesn't crash in non-debug)?

Comment 3

[Benjamin Smedberg]

I suspect we don't in B2G, and I'm sure we don't *want* to in sandboxed desktop processes. If you need a temp file, you should get the parent to create one for you and send over an open handle.

Comment 4

[Andrew Overholt [:overholt]]

So bug in the test?

Comment 5

[Andrew Overholt [:overholt]]

Martijn, when you're back from PTO next week are you able to work on the alternative way to get a temp file here?

Comment 6

[Martijn Wargers (dead)]

Sure, we can use loadChromeScript here, but I suspect it wouldn't fix the crash, because that might be because of bug 902271.

Comment 7

[Andrew Overholt [:overholt]]

Cool.  jdm told me he's going to look at bug 902271 again soon.

Comment 8

[Martijn Wargers (dead)]

Attachment: 926544.diff

Something like this.
Johnathan, this uses SpecialPowers api that was implemented in bug 914633.

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 824911 [details] [diff] [review]
926544.diff

Review of attachment 824911 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/25fd9e87b379

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/25fd9e87b379