Open Bug 926546 Opened 9 years ago Updated 4 years ago

test_input_range_mouse_and_touch_events.html | ###!!! ASSERTION: we should be in a pseudo-element that is expected to contain elements

Categories

(Core :: DOM: Events, defect, P5)

defect

Tracking

()

People

(Reporter: jgriffin, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [leave open])

Attachments

(1 file)

On debug B2G emulators, the test content/html/content/test/forms/test_input_range_mouse_and_touch_events.html is failing due to multiple instances of the following assertion:

15:00:52     INFO -  [Child 710] ###!!! ASSERTION: we should be in a pseudo-element that is expected to contain elements: 'nsCSSPseudoElements::PseudoElementContainsElements( topWithPseudoElementData->GetPseudo())', file ../../../gecko/layout/style/nsComputedDOMStyle.cpp, line 678

full log: https://tbpl.mozilla.org/php/getParsedLog.php?id=28954370&tree=Cedar&full=1#error2
smaug, can you take a quick look?
Flags: needinfo?(bugs)
I know next to nothing about nsComputedDOMStyle::GetPropertyCSSValue
David owns that code, I believe.
Flags: needinfo?(dbaron)
jwatt, could you have a look at this?

It would be interesting to know which pseudo-element this is.  (Given that we're hitting the assertion, it might be worth modifying the assertion code so that the assert text itself includes which pseudo-element it's hitting.)
Flags: needinfo?(dbaron) → needinfo?(jwatt)
Flags: needinfo?(bugs)
Blocks: 933355
I would look into this, but I've wasted many, many hours trying to get an emulator build over the last week. My latest issue is:

https://groups.google.com/forum/#!topic/mozilla.dev.b2g/CMN1DizzHWc

I think I've spent about as much time as I can afford on this though. Maybe when the B2G build process is less of a complete nightmare I can have another go.
Flags: needinfo?(jwatt)
FWIW I've emailed Vicamo (who has emulator expertise and is interested in helping with issues therein) and Gregor (whom I know uses OS X (but is involved with a work week this week)) about the emulator issue.
Thanks!
Comment on attachment 827642 [details] [diff] [review]
patch to modify the assertion as suggested in comment 3

Could you put the whole thing inside the NS_ASSERTION macro so that it all goes away in non-DEBUG builds?  (Probably the easiest way is to get rid of the 2 temporary variables and just make a bigger expression.)

r=dbaron with that
Attachment #827642 - Flags: review?(dbaron) → review+
That whole chunk of code is in an |#ifdef DEBUG| section, so that's not necessary.
Backed out for build failures on Windows:
{
e:\builds\moz2_slave\m-in-w32-d-0000000000000000000\build\config\rules.mk:1048:0$ mozbuild.action.cl main  cl -FoStyleRule.obj -c -D_HAS_EXCEPTIONS=0 -I../../dist/stl_wrappers  -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -DNOMINMAX -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL  -DNO_NSPR_10_SUPPORT -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/ipc/chromium/src -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/ipc/glue -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/obj-firefox/ipc/ipdl/_ipdlheaders -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/../base -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/dom/base -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/../generic -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/../xul/base/src -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/../../content/base/src -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/../../content/html/content/src -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/../../content/xbl/src -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/../../content/xul/document/src  -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style -I. -I../../dist/include  -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/obj-firefox/dist/include/nspr -Ie:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/obj-firefox/dist/include/nss       -MDd           -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT  -wd4099 -TP -nologo -W3 -Gy -Fdgenerated.pdb -wd4251 -wd4244 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR-  -DDEBUG -D_DEBUG -DTRACING -Zi -O1 -Oy- -WX  e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/layout/style/StyleRule.cpp
<gkstyle_s.lib.desc>: Found error
<libs>: Found error
evaluation from e:\builds\moz2_slave\m-in-w32-d-0000000000000000000\build\config\recurse.mk:186:53:7:0: command 'C:/mozilla-build/python27/python.exe e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/build/pymake/pymake/../make.py -C style libs' failed, return code 2
}

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/dc13acdbd93f
That is...weird.
I modified the patch to stop using temporaries and that seemed to make XP happy:

https://hg.mozilla.org/integration/mozilla-inbound/rev/d94d3e54da67
Attachment #827642 - Flags: checkin+
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.