926561 - Middle click on the tab bar does not close the tab

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[niravaga]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131013030202

Steps to reproduce:

1) Open firefox metro.
2) Open 2 websites in 2 separate tabs.
3) Right click on a page to display the tab bar.
4) Middle click on the image of the tab.




Actual results:

The tab does not close but it gets selected.


Expected results:

The tab should close.

Comment 1

[Karen Rudnitski [:kar]]

Need info on expected behaviour of a middle button (when it's available).

Comment 2

[Matt Brubeck (:mbrubeck)]

Desktop Firefox uses middle-click to close tabs, and it seems reasonable to extend that to Metro too.  It's handy for people who are used to it, and won't cause any problems for those who aren't.

If anyone wants to add this feature to Metro, the code is in the "click" handler here:
http://dxr.mozilla.org/mozilla-central/source/browser/metro/base/content/bindings/tabs.xml

You can add an additional "click" handler and use "button" attributes to distinguish the two handlers:
https://developer.mozilla.org/en-US/docs/XUL/Tutorial/Adding_Event_Handlers_to_XBL-defined_Elements

Comment 3

[Nick Lebedev [:nl]]

I would like to take this bug. Could you please assign it to me?

Comment 4

[Brian R. Bondy [:bbondy]]

Done, thanks for helping out!

Comment 5

[Nick Lebedev [:nl]]

Attachment: Separated click handlers for different mouse buttons. Added logic that closes selected tab on middle click.

Comment 6

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8355866 [details] [diff] [review]
Separated click handlers for different mouse buttons. Added logic that closes selected tab on middle click.

Review of attachment 8355866 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  r=mbrubeck with a minor change:

::: browser/metro/base/content/bindings/tabs.xml
@@ +31,5 @@
>  
>      <handlers>
> +      <handler event="click" button="0" clickcount="1" action="this._onClick()"/>
> +      <handler event="click" button="1" clickcount="1" action="event.stopPropagation(); this._onClose()"/>
> +      <handler event="click" button="2" clickcount="1" action="this._onClick()"/>

Please remove the button="2" handler.  We can add a contextual menu on right-click in the future, but for now it should do nothing.

Comment 7

[Nick Lebedev [:nl]]

Attachment: Separated click handlers for different mouse buttons. Added logic that closes selected tab on middle click.

Removed right click handler according to the mbrubeck request.

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/fx-team/rev/c85cbcb0e170

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c85cbcb0e170

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0		
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0		

Verified as fixed on Windows 8 and Windows 8.1 64 bit architecture using latest Aurora (build ID: 20140304004003).