926619 - WebAudio: "Assertion failure: iter->AsAudioNodeStream()"

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Jesse Ruderman]

Assertion failure: iter->AsAudioNodeStream(), at content/media/MediaStreamGraph.cpp:510

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Maire Reavy [:mreavy]]

Karl, can you look at this?

Comment 3

[(no longer active)]

Clearly our assumption that the streams in MediaStreamAudio{Source,Destination}Node cannot end up in a cycle is false.  :(

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: check for non-AudioNodeStreams in MediaStream cycles

I haven't checked whether anything should be done to mute non-AudioNodeStream
streams, but this avoids the crash and reverts to the behavior before changes
from bug 881959.

The stream still knows it is in a cycle because mInCycle is set.

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 821437 [details] [diff] [review]
check for non-AudioNodeStreams in MediaStream cycles

Review of attachment 821437 [details] [diff] [review]:
-----------------------------------------------------------------

This should be fine, yes.

Comment 6

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54c627598be1
https://hg.mozilla.org/integration/mozilla-inbound/rev/f266795178da

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/54c627598be1
https://hg.mozilla.org/mozilla-central/rev/f266795178da