This will help fuzzing, as the fuzzers know about --thread-count but not JS_THREADPOOL_SIZE
Created attachment 816904 [details] [diff] [review] Remove JS_THREADPOOL_SIZE in favor --thread-count. (r=?)
Attachment #816904 - Flags: review?(nmatsakis)
Attachment #816904 - Flags: review?(nmatsakis) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
This broke --disable-threadsafe and most of the JS fuzzing. With --disable-threadsafe --disable-debug the initialization list of ThreadPool::ThreadPool becomes empty and that's a syntax error. Also ThreadPool::numWorkers is defined unconditionally, but referring runtime_.
Created attachment 826683 [details] [diff] [review] Bug926710-Fix.diff Not sure why the runtime_ field was made conditional, I don't think it has to be. Decoder: does this help?
Comment on attachment 826683 [details] [diff] [review] Bug926710-Fix.diff Confirmed this works. Can we land this asap? It's not easy to use the patch in the production fuzzing environment.
Attachment #826683 - Flags: feedback?(choller) → feedback+
You need to log in before you can comment on or make changes to this bug.