Closed
Bug 926710
Opened 11 years ago
Closed 11 years ago
PJS: Unify --thread-count shell option and JS_THREADPOOL_SIZE env var
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: shu, Assigned: shu)
Details
(Whiteboard: [qa-])
Attachments
(2 files)
4.22 KB,
patch
|
nmatsakis
:
review+
|
Details | Diff | Splinter Review |
1.43 KB,
patch
|
decoder
:
feedback+
|
Details | Diff | Splinter Review |
This will help fuzzing, as the fuzzers know about --thread-count but not JS_THREADPOOL_SIZE
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #816904 -
Flags: review?(nmatsakis)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → shu
Status: NEW → ASSIGNED
Updated•11 years ago
|
Attachment #816904 -
Flags: review?(nmatsakis) → review+
Assignee | ||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c310a02a5954
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c310a02a5954
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Comment 4•11 years ago
|
||
This broke --disable-threadsafe and most of the JS fuzzing. With --disable-threadsafe --disable-debug the initialization list of ThreadPool::ThreadPool becomes empty and that's a syntax error. Also ThreadPool::numWorkers is defined unconditionally, but referring runtime_.
Comment 5•11 years ago
|
||
Not sure why the runtime_ field was made conditional, I don't think it has to be. Decoder: does this help?
Attachment #826683 -
Flags: review?(shu)
Attachment #826683 -
Flags: feedback?(choller)
Comment 6•11 years ago
|
||
Comment on attachment 826683 [details] [diff] [review] Bug926710-Fix.diff Confirmed this works. Can we land this asap? It's not easy to use the patch in the production fuzzing environment.
Attachment #826683 -
Flags: feedback?(choller) → feedback+
Updated•11 years ago
|
Attachment #826683 -
Flags: review?(shu)
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/631e964be07d
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•