926710 - PJS: Unify --thread-count shell option and JS_THREADPOOL_SIZE env var

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Shu-yu Guo [:shu]]

This will help fuzzing, as the fuzzers know about --thread-count but not JS_THREADPOOL_SIZE

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Remove JS_THREADPOOL_SIZE in favor --thread-count. (r=?)

Comment 2

[Shu-yu Guo [:shu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c310a02a5954

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c310a02a5954

Comment 4

[Christian Holler (:decoder)]

This broke --disable-threadsafe and most of the JS fuzzing. With --disable-threadsafe --disable-debug the initialization list of ThreadPool::ThreadPool becomes empty and that's a syntax error. Also ThreadPool::numWorkers is defined unconditionally, but referring runtime_.

Comment 5

[Niko Matsakis [:nmatsakis]]

Attachment: Bug926710-Fix.diff

Not sure why the runtime_ field was made conditional, I don't think it has to be.

Decoder: does this help?

Comment 6

[Christian Holler (:decoder)]

Comment on attachment 826683 [details] [diff] [review]
Bug926710-Fix.diff

Confirmed this works. Can we land this asap? It's not easy to use the patch in the production fuzzing environment.

Comment 7

[Niko Matsakis [:nmatsakis]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/631e964be07d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/631e964be07d