PJS: Unify --thread-count shell option and JS_THREADPOOL_SIZE env var

RESOLVED FIXED in mozilla28

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: shu, Assigned: shu)

Tracking

unspecified
mozilla28
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
This will help fuzzing, as the fuzzers know about --thread-count but not JS_THREADPOOL_SIZE
(Assignee)

Comment 1

4 years ago
Created attachment 816904 [details] [diff] [review]
Remove JS_THREADPOOL_SIZE in favor --thread-count. (r=?)
Attachment #816904 - Flags: review?(nmatsakis)
(Assignee)

Updated

4 years ago
Assignee: nobody → shu
Status: NEW → ASSIGNED
Attachment #816904 - Flags: review?(nmatsakis) → review+
https://hg.mozilla.org/mozilla-central/rev/c310a02a5954
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
This broke --disable-threadsafe and most of the JS fuzzing. With --disable-threadsafe --disable-debug the initialization list of ThreadPool::ThreadPool becomes empty and that's a syntax error. Also ThreadPool::numWorkers is defined unconditionally, but referring runtime_.
Created attachment 826683 [details] [diff] [review]
Bug926710-Fix.diff

Not sure why the runtime_ field was made conditional, I don't think it has to be.

Decoder: does this help?
Attachment #826683 - Flags: review?(shu)
Attachment #826683 - Flags: feedback?(choller)
Comment on attachment 826683 [details] [diff] [review]
Bug926710-Fix.diff

Confirmed this works. Can we land this asap? It's not easy to use the patch in the production fuzzing environment.
Attachment #826683 - Flags: feedback?(choller) → feedback+
Attachment #826683 - Flags: review?(shu)

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.