64.31 KB, patch
|Details | Diff | Splinter Review|
61.70 KB, text/html
79.13 KB, patch
|Details | Diff | Splinter Review|
2.18 KB, patch
|Details | Diff | Splinter Review|
My manager needed a summary table of bug counts. This is what I came up with. I received permission to redistribute it. The URL has an example output.
We have used the script for several months with wonderful results.
This ain't in CVS, so it ain't fixed. This might be worth adding for 2.16, but all this should eventually be superceded by general summary reports (bug #12282) which would allow this and more.
Thanks. I was not aware of the other bug. I will check it into CVS this weekend.
The attachment has the code. I made a few more small enhancements, and a bugfix, but stopped short of patching the index.html page. :-) Warning: the patch creates two new files. I had trouble determining who should review the code (and check into CVS) before I resolved the bug. Suggestions are welcome. I added some defenses for large installations like mozilla. The script now pre-counts the bugs in the SQL server to stop you from wasting your time. The limit is adjustable at the bottom of the form. It would also be good to have limits for the number of rows and columns. Please let me know if this is needed for open source project bug databases. My company only has 50 people, and it works well as is. I don't like all the GenerateSQL() code I duplicated from buglist.cgi. This would be to move into another file, and I would be willing to try it if requested, but it is easier to install on a 2.12 or 2.10 implementation this way. There are some queries which would work better by having the SQL server do the counts, but I am not that much of a SQL guru, and many queries work better the current way. The next big enhancement, would be to add time as another axis choice.
This still hasn't passed through the review and check in stages, so it's not yet FIXED. Re-opening so the patch can be evaluated (this bug already contains the patch and review keywords).
A reviewer will come to this bug ASAP. But bear in mind that we're currently in the process of finalising 2.14, so no code is being accepted that isn't necessary for that, and when 2.16 begins we've 91 patches to review, so this may take a little while.
See also bug 77764.
Gerv, can this (or some other generic bugcounting mechanism) be checked in soon?
See bug 9789. I think doing what I suggest there would be a very good start. I'm not sure if the cgi attached to this bug has general utility; perhaps it could go into contrib. Gerv
OK, I didn't quite get the point here. Here are some more sane comments: I like the idea of this, but I think duplicating all that query page UI is the wrong way to do it. What I'd ideally like to see is a "twisty" on the query page which gives access to the extra UI needed to get a table instead of a buglist. rdean: what do you think? Gerv
See also the comments from Dave Miller 2001-09-07 20:02 in bug 16775, where he talks about a search.cgi as a more generic successor of query.cgi.
Why do we need the buglist fields on the results page? We don't have it anywhere else - that's what the back button is for. I'd rather see this on two pages just like query. I also would like to see the buglist fields HTML moved to CGI.pl. I want this for when I generalise summary reports further.
What is "buglist fields"? Are you talking about the query form?
I am talking about the fields that determine what bugs are considered. For example, on the query page, this is currently pretty much everything except sort ordering, but would also not include things like column specifications, colours, "count only" etc if and when they were added to the query page. The idea is that these fields are reusable throughout the product.
Created attachment 49554 [details] [diff] [review] new patch replaces old, has minimal duplicate code but different UI
The way forward here is to templatise query.cgi. When this is done, the common UI can be factored out and made part of two templates - one for query.cgi and one for tables.cgi . Gerv
Gerv, I think the idea here was to offer the additional form elements for the "table" stuff on the query page, but only upon request (the same way additional boolean charts are only offered upon request currently). This is completely independent of templates. If you are planning to templatize query.cgi in the near future, feel free to do so, but otherwise I can't see a single reason why this should wait.
query.cgi is being templatised as part of kiko and mpt's UI rewrite. If I made mods to the query.cgi UI at the moment, it would mess them up. I'd rather wait for them to land. I've told kiko his bug blocks this one, and he promised to look at it this week. Patience :-) Gerv
1) The latest patch can be applied to current versions of CGI.pl, query.cgi and buglist.cgi . You also need to chmod a+x counts_table.cgi . If you are lucky, you can see this patch in action at http://bugzilla.mathweb.org/query.cgi (the "Use table of bug counts." link will turn on the tables stuff). 2) I can't find a "Target Milestone" selection on any of the axes. I can imagine that this would be the most useful thing on installations like b.m.o. How hard would it be to add support for that? 3) A bug: For empty QA contacts, it showed a count of "2" in one of the fields, but when I clicked on it, the result was a list of 19 (!) bugs. Something is wrong here. 4) kiko: is there any chance to get this checked into bugzilla before Myk upgrades to the tip (bug 103885)? Please let's try to avoit bitrotting this if at all possible...
Gerv, kiko, myk: If you don't want to mess with query.cgi at the moment, what about the following solution: Until query.cgi is templatized, check in the previous patch (attachment 44762 [details] [diff] [review]). That patch is pretty much just a single new extra file, so it can easiliy be removed when the real patch lands. This way, we can have our cake and eat it, too: query.cgi can be templatized first, and b.m.o can generate bugcount tables. If you like, you can even make it a hidden feature by not including the link to table_of_bug_counts.cgi in the command menu in the footer.
Created attachment 53278 [details] [diff] [review] Patch to newer patch (49554) for Andrea's concerns
We are currently trying to wrap up Bugzilla 2.16. We are now close enough to release time that anything that wasn't already ranked at P1 isn't going to make the cut. Thus this is being retargetted at 2.18. If you strongly disagree with this retargetting, please comment, however, be aware that we only have about 2 weeks left to review and test anything at this point, and we intend to devote this time to the remaining bugs that were designated as release blockers.
I keep losing this bug! I would assign it to me, but I didn't make the patches. Note to self: This is the bug you keep looking for, and you can find it by searching comments for the (probably unique in Bugzilla ;-) string "jesusislordatchristmas". ;-) By the way, now that query.cgi has landed, I am working on integrating this stuff. Gerv
I think this has some overlap with bug 125798 ("move buglist sub-routines into re-usable module"). That one will probably land first. Marking dependency.
There is nothing to look at here yet, since Gerv is in the process of integrating the old patches into the new code. Removing review keyword for now.
The work for this is going on in bug 12282. It takes serious inspiration from the code attached to this bug - so many thanks to rdean, who has a credit in the source. Gerv *** This bug has been marked as a duplicate of 12282 ***
removing target milestone from WONTFIX/INVALID/WORKSFORME/DUPLICATE bugs so they'll show up as untriaged if they get reopened.