926842 - unable to change status and tracking flag values once they are set

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Mark Banner (:standard8)]

I've just noticed that I'm no longer able to change the status of some tracking flags for Thunderbird. There's no errors/warnings given, it just doesn't happen.

So far, flags I've found affected are:

tracking-thunderbird24
tracking-thunderbird25
status-thunderbird24

These were all set to a value to begin with.

tracking-thunderbird-esr24 did work, but only in the case it was unset to begin with.

Comment 1

[Jason Smith [:jsmith]]

This seems to also affect the blocking-b2g flags as well.

Comment 2

[David Lawrence [:dkl]]

(In reply to Mark Banner (:standard8) from comment #0)
> I've just noticed that I'm no longer able to change the status of some
> tracking flags for Thunderbird. There's no errors/warnings given, it just
> doesn't happen.
> 
> So far, flags I've found affected are:
> 
> tracking-thunderbird24
> tracking-thunderbird25
> status-thunderbird24
> 
> These were all set to a value to begin with.
> 
> tracking-thunderbird-esr24 did work, but only in the case it was unset to
> begin with.

Can you provide a bug id or two that exhibit this behavior to aid us in debugging the issue?

dkl

Comment 3

[Jason Smith [:jsmith]]

For B2G btw - https://bugzilla.mozilla.org/show_bug.cgi?id=926746 is an example.

Comment 4

[:glob ✱]

confirming and taking; looks like you can set a value directly to koi+, but not change it from koi? to koi+.

Comment 5

[David Lawrence [:dkl]]

(In reply to Mark Banner (:standard8) from comment #0)
> I've just noticed that I'm no longer able to change the status of some
> tracking flags for Thunderbird. There's no errors/warnings given, it just
> doesn't happen.
> 
> So far, flags I've found affected are:
> 
> tracking-thunderbird24
> tracking-thunderbird25
> status-thunderbird24

these flags are configured to display for certain products such as Thunderbird, MailNews Core, Mozilla Messaging, and support.mozillamessaging.com and I can see those when looking at a bug in one of those products. Can you provide a bug id from those where you are seeing this issue?

dkl

Comment 6

[:glob ✱]

Attachment: 926842_1.patch

Comment 7

[David Lawrence [:dkl]]

Comment on attachment 817188 [details] [diff] [review]
926842_1.patch

Review of attachment 817188 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 8

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/TrackingFlags/Extension.pm
Committed revision 9067.

i will try to get this pushed to prod asap.

Comment 9

[:glob ✱]

this has been pushed to production.