Closed Bug 926962 Opened 7 years ago Closed 7 years ago

all tracking flags are visible on the 'change many bugs at once' page

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: dkl)

References

()

Details

Attachments

(1 file)

all tracking flags are visible on the 'change many bugs at once' page, and we have a few :)
Attached patch 926962_1.patchSplinter Review
I seem to remember this being the case before when we were using custom fields instead as well so not a regression. I would need to look back at the old tracking flag code to compare. 

Upstream and our template code both just display all active_custom_field with no product/component filtering when viewing the edit mulptiple form.

This patch will filter the flags down based on product if only one product is present in the bug results (one_product). Otherwise if multiple products are returned we fall back to old behavior. Bugzilla::active_custom_fields does not yet support multiple products for filtering, but if it did we could extend this to the edit multiple form as well which would still decrease the list of flags significantly.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #817418 - Flags: review?(glob)
Comment on attachment 817418 [details] [diff] [review]
926962_1.patch

Review of attachment 817418 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #817418 - Flags: review?(glob) → review+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2
modified template/en/default/list/edit-multiple.html.tmpl
Committed revision 9258
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Extensions: TrackingFlags → Extensions
You need to log in before you can comment on or make changes to this bug.