Closed
Bug 926997
Opened 12 years ago
Closed 12 years ago
Eideticker noise caused by "WatcherService created" toast message
Categories
(Testing Graveyard :: SUTAgent, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: Margaret, Assigned: gbrown)
References
Details
Attachments
(1 file)
|
6.41 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
I'm not familiar with the WatcherSerivce, but what's the reason for this toast message? It's throwing off eideticker results, so can we remove it an replace it with a log message instead?
http://eideticker.wrla.ch/framediff-view.html?title=Frame%20Difference%20Startup%20to%20about:home%20%28fresh%20profile%29%20%282013-10-14%29&video=videos/video-1381822474.13.webm&framediff=framediffs/framediff-1381822484.12.json&actionlog
| Assignee | ||
Comment 1•12 years ago
|
||
I don't find the watcher toasts useful. I would be happy to just have corresponding log messages.
On a side-note, I find it odd that the watcher is starting during a test...but I am not that familiar with the eideticker device setup. :wlach -- any thoughts here?
Flags: needinfo?(wlachance)
Comment 2•12 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #1)
> I don't find the watcher toasts useful. I would be happy to just have
> corresponding log messages.
>
> On a side-note, I find it odd that the watcher is starting during a
> test...but I am not that familiar with the eideticker device setup. :wlach
> -- any thoughts here?
Probably got killed due to low memory, then it came back. I agree, it would be great to get rid of the toasts.
Flags: needinfo?(wlachance)
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → gbrown
| Assignee | ||
Comment 3•12 years ago
|
||
Change doToast() to Log.i/w/e. Update version to 1.17.
I noticed a second "WatcherService created" message and changed that to something more descriptive.
Attachment #817503 -
Flags: review?(wlachance)
Comment 4•12 years ago
|
||
Comment on attachment 817503 [details] [diff] [review]
eliminate toasts
Great, thanks!
Attachment #817503 -
Flags: review?(wlachance) → review+
| Assignee | ||
Comment 5•12 years ago
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•