927209 - Fix -Wunused-function and -Wreorder warnings in security/manager/ssl/src/nsNSSIOLayer.cpp

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-nsNSSIOLayer-warnings.patch

These two build warnings are regressions from bug 839310:

security/manager/ssl/src/nsNSSIOLayer.cpp:77:1 [-Wunused-function] unused function 'getSiteKey'
security/manager/ssl/src/nsNSSIOLayer.cpp:1208:3 [-Wreorder] field 'mutex' will be initialized after field 'mRenegoUnrestrictedSites'


Bug 839310 added two overloads of function getSiteKey(), but only called one. Rather than remove the unused function [1], this patch changes one of the call sites to call the unused function because it simplifies the code.

[1] https://hg.mozilla.org/integration/mozilla-inbound/annotate/5db1f111ac19/security/manager/ssl/src/nsNSSIOLayer.cpp#l77

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 817533 [details] [diff] [review]
fix-nsNSSIOLayer-warnings.patch

Review of attachment 817533 [details] [diff] [review]:
-----------------------------------------------------------------

Please revert the getSiteKey() call and remove the unused variant. I intentionally wanted to remove the dependency on nsNSSSocketInfo.

Comment 2

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19caec7fe32d

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19caec7fe32d