927321 - Disable auto-correction for "Greek + SMS" keyboard layout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a follow-up for Bug #914454 +++

The auto correction feature would be enabled by default for v1, and in Bug #914454, we have implemented a special "Greek + SMS" keyboard layout for all uppercase input for SMS and the word suggestion is disabled with that patch.

This bug is to disable auto correction as well.

Comment 1

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12900

Pointer to Github pull-request

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 817992 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12900

Hi David,

Please help review this patch as a follow-up of Bug 914454, with which I failed to notice that I should disable auto correction as well for this special "Greek + SMS" keyboard.

As another "band-aided" patch for this late change to v1-train, I admit that the patch does not look elegant but it should be able to work.

BTW, I also modified the naming of this special inputmode from "-moz-sms-7bit" to "-moz-sms" as suggested by Julien.

Comment 3

[Julien Wajsberg [:julienw]]

(In reply to Rudy Lu [:rudyl] from comment #2)

> BTW, I also modified the naming of this special inputmode from
> "-moz-sms-7bit" to "-moz-sms" as suggested by Julien.

mmm for v1-train I'd rather not do this, and keep the patch as small as possible...

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to Julien Wajsberg [:julienw] from comment #3)
> (In reply to Rudy Lu [:rudyl] from comment #2)
> 
> > BTW, I also modified the naming of this special inputmode from
> > "-moz-sms-7bit" to "-moz-sms" as suggested by Julien.
> 
> mmm for v1-train I'd rather not do this, and keep the patch as small as
> possible...

Advice taken.
I have updated the pull request to make this a minimal change.

Thanks.

Comment 5

[David Flanagan [:djf]]

Comment on attachment 817992 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12900

I'd strongly prefer it if you could fix this bug without adding a method to latin.js, even if that means using 8-bit Greek characters and autocorrection in certain corner cases. It feels to me like there is significant risk in that part of this patch.

The rest of the patch looks good to me, but see my nits on github.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

** For Triage **

This is a follow up for bug 914454 (leo+) that we should disable auto-correction for greek SMS.
Without this change, the user might easily switch back to 70 chars for a single message, so nominate it as leo+.

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

i just tried it myself.
this should land. without this patch, the user experience is horrible that user needs to also hit backkey to reverse the autocorrect to make sure everything stay capitalized

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I would like to keep the original approach since this would keep the UX as is when we switch from English layout to Greek and vice versa.
The other nits have been addressed.

David, thanks for the review.

--
Merged to Gaia v1-train
https://github.com/mozilla-b2g/gaia/commit/39b0203fa9809052c8c4d4332fef03bbaf0426fc

The patch won't be uplifted to v1.2 since we need to a separate patch for this "Greek SMS" layout on v1.2.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 39b0203fa9809052c8c4d4332fef03bbaf0426fc
v1.1.0hd: e7287598c65947cffaaa806ee955e6f472bb6078