927364 - make Balrog ride the trains to Aurora

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Like bug 885477, but for Aurora! Most of the work here is deciding when to do the switchover. We also have to adjust the code that protects an accidental uplift to allow Nightly and Aurora to be on aus4.mozilla.org, but not allow Beta, Release, or ESR release builds.

Bug 885477 has a lot of context on how the original switch for Nightly was done.

Comment 1

[[e-mail] (:bhearsum)]

The switch for Nightly has been going well for a few weeks now:
* Our uptake has stayed steady (Metrics looked at that in bug 922818).
* The aus4.mozilla.org systems have served over 4 million requests without ever hitting notable load.
* The only bug report that has come in is bug 925650, which is unrepro'able, and I suspect related to the users local network, not aus4.mozilla.org.

Given that, I think we should let this ride the trains with 27.0. Nick, Alex - what do you think?

Comment 2

[Alex Keybl [:akeybl]]

Agreed, let's do it!

Comment 3

[[e-mail] (:bhearsum)]

Attachment: switch update server logic to only exclude releases

Based on my reading of https://github.com/mozilla/mozilla-central/blob/master/configure.in#L3589 it looks like we'll use Balrog for everything except Beta, Release, and ESR release-style builds. This means that Nightly (+ project branches with nightly builds), Aurora, and the next ESR branches' nightly builds will point at aus4.mozilla.org. The net change here is really only Aurora though, as everything mozilla-central based with nightlies has already been switched, and the next ESR isn't due for a long time.

Still need ack from Nick to land, but I wanted to get this up to make sure I have time to fix this up if necessary.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 817809 [details] [diff] [review]
switch update server logic to only exclude releases

r=me on the switch from ifdef NIGHTLY_BUILD to ifndef RELEASE_BUILD, though I haven't checked that you've made all of the necessary changes (I'm assuming you know that much better than I and don't need me to verify that)

Comment 5

[[e-mail] (:bhearsum)]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #4)
> Comment on attachment 817809 [details] [diff] [review]
> switch update server logic to only exclude releases
> 
> r=me on the switch from ifdef NIGHTLY_BUILD to ifndef RELEASE_BUILD, though
> I haven't checked that you've made all of the necessary changes (I'm
> assuming you know that much better than I and don't need me to verify that)

Yeah, we've already made all of the necessary changes in terms of pointing at the correct update server, cert pinning, etc. I can run this by someone else if you want a double check there, though. Just noticed I need to update a couple of comments ("// Nightly builds have switched over...") that need updating, too.

Comment 6

[Robert Kaiser]

Umm, this patch should include adding the ifdef to Android, where you forgot it in the other bug :)

Comment 7

[[e-mail] (:bhearsum)]

(In reply to Robert Kaiser (:[e-mail]) from comment #6)
> Umm, this patch should include adding the ifdef to Android, where you forgot
> it in the other bug :)

No Android builds beyond Aurora use AUS, I don't think it matters...

Comment 8

[Robert Kaiser]

(In reply to Ben Hearsum [:bhearsum] from comment #7)
> No Android builds beyond Aurora use AUS, I don't think it matters...

Ah, right, ignore me, then. ;-)

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Fine by me.

Comment 10

[[e-mail] (:bhearsum)]

Attachment: allow balrog for aurora but not release for thunderbird

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 818419 [details] [diff] [review]
allow balrog for aurora but not release for thunderbird

There's an implicit a=me to land on comm-aurora when you're ready.

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Mark Banner (:standard8) from comment #11)
> Comment on attachment 818419 [details] [diff] [review]
> allow balrog for aurora but not release for thunderbird
> 
> There's an implicit a=me to land on comm-aurora when you're ready.

Sorry for the confusion - I won't actually be doing this. I'm just going to adjust the code in mozilla-central so that this rides the trains with 27.

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 818419 [details] [diff] [review]
allow balrog for aurora but not release for thunderbird

https://hg.mozilla.org/comm-central/rev/b6caffee2274

Comment 14

[[e-mail] (:bhearsum)]

Comment on attachment 817809 [details] [diff] [review]
switch update server logic to only exclude releases

https://hg.mozilla.org/integration/mozilla-inbound/rev/030f1de777ae

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/030f1de777ae