927365 - Make the implicit form submission code aware of <input type=number>

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonathan Watt [:jwatt]]

It turns out that bug 927125 is invalid, so I need the implicit form submission code to be aware of <input type=number>. That is, the code implementing:

http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 817788 [details] [diff] [review]
patch

Some test would be really nice.

Comment 3

[Jonathan Watt [:jwatt]]

We have tests. Specifically content/html/content/test/forms/test_input_typing_sanitization.html tests this. The reason that it fails with the patch for bug 635240 is that IsSingleLineTextControl no longer returns true for NS_FORM_INPUT_NUMBER.

Comment 4

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8d05aed2a07

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8d05aed2a07