Closed Bug 927365 Opened 7 years ago Closed 7 years ago

Make the implicit form submission code aware of <input type=number>

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

It turns out that bug 927125 is invalid, so I need the implicit form submission code to be aware of <input type=number>. That is, the code implementing:

http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#implicit-submission
Attached patch patchSplinter Review
Attachment #817788 - Flags: review?(bugs)
Comment on attachment 817788 [details] [diff] [review]
patch

Some test would be really nice.
Attachment #817788 - Flags: review?(bugs) → review+
We have tests. Specifically content/html/content/test/forms/test_input_typing_sanitization.html tests this. The reason that it fails with the patch for bug 635240 is that IsSingleLineTextControl no longer returns true for NS_FORM_INPUT_NUMBER.
https://hg.mozilla.org/mozilla-central/rev/e8d05aed2a07
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.