Closed
Bug 927371
Opened 12 years ago
Closed 12 years ago
Remove performEmptySearch from SearchLoader if possible
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: lucasr, Assigned: lucasr)
Details
Attachments
(1 file)
|
4.15 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
We guard against empty search terms in BrowserApp anyway.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #817833 -
Flags: review?(sriram)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → lucasr.at.mozilla
|
|
||
Comment 2•12 years ago
|
||
We don't want to do empty search?
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #2)
> We don't want to do empty search?
IIUC, performEmptySearch was meant to be used by BrowserSearch to avoid running queries with empty search terms. But we already guard against that in BrowserApp (which is a better place to do it as it's even before the loader is triggered). PinSiteDialog, on the other hand, does run the query with empty search term and is unaffected by this patch.
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 817833 [details] [diff] [review]
Remove performEmptySearch from SearchLoader (r=sriram)
Review of attachment 817833 [details] [diff] [review]:
-----------------------------------------------------------------
All good then.
Attachment #817833 -
Flags: review?(sriram) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•