Make xpc::SystemErrorReporter() system JS exception fprintf()s not split the error across two lines

RESOLVED FIXED in mozilla27

Status

()

Core
XPConnect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Trunk
mozilla27
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Until bug 920191 is fixed, there are a fair number of spammy JS exceptions in our automation logs, that get picked up by the TBPL parser regexp, but yet don't cause the run to fail. 

These cause confusion in non-green runs, since they appear in the brief log summary on TBPL, often hiding the real failure for that run.

Bug 910614 will presumably make these failures (and other chrome js exceptions) output fail the run & output a TBPL compatible failure line, but for now they are unhelpful.

To avoid the false positives, let's remove the newline midway through:
http://hg.mozilla.org/mozilla-central/file/febfe3c7732b/js/xpconnect/src/nsXPConnect.cpp#l261

...so we don't match TBPL's regexp for Python exceptions:
https://hg.mozilla.org/webtools/tbpl/file/16e6a0cc29c0/php/inc/GeneralErrorFilter.php#l47
(Assignee)

Comment 1

5 years ago
Created attachment 817815 [details] [diff] [review]
Patch v1

Output is currently of form:
05:56:52     INFO -  System JS : ERROR resource://gre/modules/DataStore.jsm:38
05:56:52     INFO -                       TypeError: can't access dead object

This change will avoid the TBPL parser false positives against the 2nd line, until bug 920191 is fixed.
Attachment #817815 - Flags: review?(bobbyholley+bmo)
Attachment #817815 - Flags: review?(bobbyholley+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/6233dd77e3f8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
(Assignee)

Updated

4 years ago
Blocks: 1023988
You need to log in before you can comment on or make changes to this bug.