Closed Bug 927394 Opened 12 years ago Closed 12 years ago

Intermittent TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox25 unaffected, firefox26 unaffected, firefox27 fixed, firefox-esr24 unaffected)

Status:
RESOLVED FIXED
Milestone:
Firefox 27
Tracking Flags:
Tracking Status
firefox25 --- unaffected
firefox26 --- unaffected
firefox27 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: cbook, Assigned: paul.feher)

References

(
URL
)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

testReaderMode fix
3.53 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
Android 2.2 Tegra mozilla-central opt test robocop-2 on 2013-10-16 05:15:03 PDT for push c14ca6b27b30 slave: tegra-150 https://tbpl.mozilla.org/php/getParsedLog.php?id=29186747&tree=Mozilla-Central 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 8 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Exception caught - junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:53.365 I/Robocop ( 8764): 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:53.425 I/Robocop ( 8764): junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:53.425 I/Robocop ( 8764): 8 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Exception caught - junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:54.565 I/TestRunner( 8764): junit.framework.AssertionFailedError: 8 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Exception caught - junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:53.365 I/Robocop ( 8764): 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:53.425 I/Robocop ( 8764): junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:53.425 I/Robocop ( 8764): 8 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Exception caught - junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present 10-16 06:07:54.565 I/TestRunner( 8764): junit.framework.AssertionFailedError: 8 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Exception caught - junit.framework.AssertionFailedError: 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present
Paul, are the long-click coordinates here correct? 10-16 06:07:32.165 D/GeckoLayerClient( 8764): Screen-size changed to (768,1024) 10-16 06:07:32.165 D/GeckoLayerClient( 8764): Window-size changed to (768,951) 10-16 06:07:32.465 I/Robocop ( 8764): 6 INFO TEST-PASS | testReaderMode | Page title is correct - Robocop Text Page should equal Robocop Text Page 10-16 06:07:32.465 I/Robocop ( 8764): Long Clicking at width = 758 and height = 1014 10-16 06:07:34.135 D/GeckoFavicons( 8764): Cancelling favicon load (10) 10-16 06:07:34.135 E/FaviconForURL( 8764): No primaries found in Favicon cache structure. This is madness! 10-16 06:07:34.215 W/GeckoGlobalHistory( 8764): Rebuilding visited link set... 10-16 06:07:35.895 E/Profiler( 8764): BPUnw: [7 total] thread_unregister_for_profiling(me=0x2793e0) 10-16 06:07:52.125 E/GeckoConsole( 8764): [JavaScript Warning: "WARN addons.updates: Request failed: http://10.250.49.162:30150/extensions-dummy/updateBackgroundURL - 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 469}] 10-16 06:07:52.125 E/GeckoConsole( 8764): [JavaScript Warning: "WARN addons.updates: Request failed: http://10.250.49.162:30150/extensions-dummy/updateBackgroundURL - 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 469}] 10-16 06:07:52.125 E/GeckoConsole( 8764): [JavaScript Warning: "WARN addons.updates: Request failed: http://10.250.49.162:30150/extensions-dummy/updateBackgroundURL - 404: Not Found" {file: "resource://gre/modules/AddonUpdateChecker.jsm" line: 469}] 10-16 06:07:53.365 I/Robocop ( 8764): 7 INFO TEST-UNEXPECTED-FAIL | testReaderMode | Waiting for the share menu - The share menu is present
Flags: needinfo?(paul.feher)
Adding waiting periods to fix this intermittent fails for slower devices Looks ok on try server https://tbpl.mozilla.org/?tree=Try&rev=4242af801ae1
Attachment #818896 - Flags: review?(gbrown)
Flags: needinfo?(paul.feher)
Comment on attachment 818896 [details] [diff] [review] testReaderMode fix Review of attachment 818896 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/tests/testReaderMode.java.in @@ +29,5 @@ > Actions.EventExpecter contentEventExpecter; > Actions.EventExpecter contentReaderAddedExpecter; > Actions.EventExpecter faviconExpecter; > + Actions.EventExpecter contentPageShowExpecter; > + Actions.RepeatedEventExpecter paintExpecter = mActions.expectPaint(); " = mActions.expectPaint()" is not necessary here. Remove it unless you have a good reason for keeping it.
Attachment #818896 - Flags: review?(gbrown) → review+
(In reply to Geoff Brown [:gbrown] from comment #7) > Comment on attachment 818896 [details] [diff] [review] > testReaderMode fix > > Review of attachment 818896 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: mobile/android/base/tests/testReaderMode.java.in > @@ +29,5 @@ > > Actions.EventExpecter contentEventExpecter; > > Actions.EventExpecter contentReaderAddedExpecter; > > Actions.EventExpecter faviconExpecter; > > + Actions.EventExpecter contentPageShowExpecter; > > + Actions.RepeatedEventExpecter paintExpecter = mActions.expectPaint(); > > " = mActions.expectPaint()" is not necessary here. Remove it unless you have > a good reason for keeping it. Yes this is necessary because I'm waiting for the page to be fully loaded in the Reader Mode. This ensures that I can access the reader toolbar. Is mainly necessary for slow devices.
Keywords: checkin-needed
Can we integrate this patch?
Flags: needinfo?(gbrown)
Thanks for the needinfo -- I didn't notice your question earlier. Your patch had 2 expectPaint() calls in a row, without a blockFor... in between them. I took the liberty of removing the first one; my apologies in advance if I somehow misunderstood this. https://hg.mozilla.org/integration/mozilla-inbound/rev/dd124524d90f
Assignee: nobody → paul.feher
Flags: needinfo?(gbrown)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dd124524d90f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: