Closed Bug 927427 Opened 7 years ago Closed 7 years ago

use __LP64__ in FileUtils.cpp for Linux

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: froydnj, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I missed that Linux needed this conversion too, just like OSX.
Comment on attachment 817862 [details] [diff] [review]
use __LP64__ in FileUtils.cpp for Linux

Why does it need this conversion? I thought that the LP64 stuff was some mac-specific issue.
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Comment on attachment 817862 [details] [diff] [review]
> use __LP64__ in FileUtils.cpp for Linux
> 
> Why does it need this conversion? I thought that the LP64 stuff was some
> mac-specific issue.

__LP64__ is the "standard" unix-ish define for indicating the machine has 64-bit longs and 64-bit pointers.  So it works for indicating 64-bitness on GCC/Linux just as well as clang/OSX.
Comment on attachment 817862 [details] [diff] [review]
use __LP64__ in FileUtils.cpp for Linux

ok... although aren't there 64-bit architectures which aren't lp64? ilp64, for example. It probably doesn't matter in practice, but I do wonder why we're bothering to make this change at all.
Attachment #817862 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> Comment on attachment 817862 [details] [diff] [review]
> use __LP64__ in FileUtils.cpp for Linux
> 
> ok... although aren't there 64-bit architectures which aren't lp64? ilp64,
> for example. It probably doesn't matter in practice, but I do wonder why
> we're bothering to make this change at all.

The idea is to either (a) get rid of HAVE_64BIT_OS so that universal mac builds become easier; or (b) reduce HAVE_64BIT_OS to something only makefiles and win32 cares about.  But it's an open question how much we would care about faster universal mac builds (e.g. if we dropped 32-bit support).  I need to post to dev-planning about that.
https://hg.mozilla.org/mozilla-central/rev/d3e014a0b5ad
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.