Closing a window with a sidebar open does not fire a 'detach' event

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evold, Assigned: evold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Will reported this by email.  Also should make sure that the 'hide' event fires.
The 'hide' event also does not fire, and I'm not sure if it should.  I'm guessing that both the 'detach' and 'hide' event should fire when the window housing them closes.  I'll confirm that is what happens with panels and some other modules.
Flags: needinfo?(rFobic)
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> The 'hide' event also does not fire, and I'm not sure if it should.  I'm
> guessing that both the 'detach' and 'hide' event should fire when the window
> housing them closes.  I'll confirm that is what happens with panels and some
> other modules.

Yep, this is how panel works.
Created attachment 818061 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

Pointer to Github pull-request
Attachment #818061 - Flags: review?(zer0)
Assignee: nobody → evold
Priority: -- → P2
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> The 'hide' event also does not fire, and I'm not sure if it should.  I'm
> guessing that both the 'detach' and 'hide' event should fire when the window
> housing them closes.  I'll confirm that is what happens with panels and some
> other modules.

To be fare panel actually get's hidden when you try to close window so it's more like a side effect.
Flags: needinfo?(rFobic)
Comment on attachment 818061 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

r+ with the `.then(null, assert.fail)` added and the panel's test removed from this patch.
Attachment #818061 - Flags: review?(zer0) → review+

Comment 6

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/ec4a1b4efe603ea76b675593b54304e8c3ac5089
Bug 927524 Closing a window with a sidebar open does not fire a detach or hide event

https://github.com/mozilla/addon-sdk/commit/e3d41c3201ae6564ecd99ddf321a172eb92571b9
Merge pull request #1267 from erikvold/927524

Bug 927524 Closing a window with a sidebar open does not fire a detach or hide event r=@zer0
Blocks: 888774
Comment on attachment 818061 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

[Approval Request Comment]
User impact if declined: A new Jetpack api will not emit events when they should be.  Early adopters will have to write work arounds.

Testing completed (on m-c, etc.): yes

Risk to taking this patch (and alternatives if risky): Low/No risk
Attachment #818061 - Flags: approval-mozilla-aurora?
Comment on attachment 818061 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1267

Clearing the nom still the question above is clear.
Attachment #818061 - Flags: approval-mozilla-aurora?
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.