Flatfish: Homescreen swipe should not cause buffer rotation

RESOLVED WORKSFORME

Status

()

P2
normal
RESOLVED WORKSFORME
5 years ago
4 years ago

People

(Reporter: milan, Assigned: pchang)

Tracking

({perf})

unspecified
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(tracking-b2g:backlog)

Details

(Whiteboard: [c=uniformity p= s=2014.03.14 u=])

See https://bugzilla.mozilla.org/show_bug.cgi?id=920921#c55  Homescreen wipe should not cause a buffer rotation to happen.  Other bugs are handling the efficiency of rotation/unrotate, but this bug is to remove the reason for those optimizations.
blocking-b2g: --- → 1.3?
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Milan - Can you clarify why this is a homescreen bug and not a gfx bug?
Flags: needinfo?(milan)
https://bugzilla.mozilla.org/show_bug.cgi?id=920921#c55 has a proposal as to a change to homescreen should be: "We should never ever hit buffer rotation. We should just pre-render whole planes. We need a separate bug for this and have to see what triggers the buffer rotation."
Flags: needinfo?(milan)
Keywords: perf
Milan, can you triage this for 1.3? Is this blocking?
Flags: needinfo?(milan)
Should be blocking, but according to https://bugzilla.mozilla.org/show_bug.cgi?id=920921#c75, we have patches that fix this.  Assigning to Peter as he is assigned to bug 920921.
Assignee: nobody → pchang
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(milan)
Component: Gaia::Homescreen → Graphics
Product: Firefox OS → Core

Updated

5 years ago
Status: NEW → ASSIGNED
Whiteboard: [c=effect p= s= u=1.3]

Updated

5 years ago
Summary: Homescreen wipe should not cause buffer rotation → Homescreen swipe should not cause buffer rotation
Whiteboard: [c=effect p= s= u=1.3] → [c=handeye p= s= u=1.3]
Looks like this should be linked to the flatfish parent bug.
Blocks: 920921

Comment 6

5 years ago
Moving from 1.3+ to 1.4+ since Flatfish will use 1.4.
blocking-b2g: 1.3+ → 1.4+
Summary: Homescreen swipe should not cause buffer rotation → Flatfish: Homescreen swipe should not cause buffer rotation
Whiteboard: [c=handeye p= s= u=1.3] → [c=handeye p= s= u=1.4]

Updated

5 years ago
Whiteboard: [c=handeye p= s= u=1.4] → [c=handeye p= s= u=flatfish]

Comment 7

5 years ago
FxOS Perf P1 as this has a direct negative impact on Frame Uniformity.

Milan, do these findings also apply to our non-flatfish devices?
Flags: needinfo?(milan)
Priority: -- → P1
Sure, but it doesn't show because of the smaller resolution and faster gralloc implementation.  I think this is still actionable, on the Gaia (layout?) side, even though the bug 915673 will get rid of buffer rotation in the first place.
Flags: needinfo?(milan)
(In reply to Milan Sreckovic [:milan] from comment #8)
> Sure, but it doesn't show because of the smaller resolution and faster
> gralloc implementation.  I think this is still actionable, on the Gaia
> (layout?) side, even though the bug 915673 will get rid of buffer rotation
> in the first place.

That was meant to be bug 963073, rather than 915673.
This doesn't fall under the QC blocking feature list & DSDS feature list. Renoming.
blocking-b2g: 1.4+ → 1.4?
Moving to backlog - flatfish doesn't hit the QC feature list & DSDS feature list.
blocking-b2g: 1.4? → backlog
As long as we don't back out tiling this now should be fixed WFM.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME

Updated

5 years ago
Priority: P1 → P2
Whiteboard: [c=handeye p= s= u=flatfish] → [c=uniformity p= s=2014.03.14 u=]
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.