927586 - B2G desktop mochitests | application crashed [@ nsDOMWindowUtils::GetIsTestControllingRefreshes(bool*)]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew Halberstadt [:ahal]]

E.g: https://tbpl.mozilla.org/php/getParsedLog.php?id=29203971&tree=Cedar#error2

This happens on a handful of tests, including:
content/base/test/test_bug326337.html
content/base/test/test_bug426646.html
content/base/test/test_bug557892.html
content/events/test/test_bug322588.html

There are likely more that I'll uncover as triaging progresses. Note that I can't reproduce this locally.

Comment 1

[Andrew Halberstadt [:ahal]]

Bug 895345 possibly related?

Comment 2

[Andrew Halberstadt [:ahal]]

Honza, does this crash look like it could be related to bug 895345? If so who can I bug to help me look into it?

Thanks!

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Oh, yes, that method is totally missing a nullcheck.
Patch coming.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Based on how testing framework uses this method, returning false is probably
the safest option. Other option would be to throw.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/999ed39dc0e7

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/999ed39dc0e7