Closed Bug 927649 Opened 7 years ago Closed 7 years ago

for-of iterator result should use object literal syntax instead of Object.create(null)

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

(Whiteboard: [c= p=1 s= u=])

Attachments

(1 file)

for-of-iter-obj-literal.patch
1.61 KB, patch
jorendorff
: review+
Details | Diff | Splinter Review 
As discussed in bug 907077 comment 78 and comment 80 the es6 for-of iterator implementation should use object literal syntax instead of Object.create(null).  This is for two reasons:

 1) The spec says that the result should have %ObjectPrototype% as is its prototype.
 2) Its faster.

Patch to come.
Duplicate of this bug: 927619
Attachment #818137 - Flags: review?(jorendorff)
Attachment #818137 - Flags: review?(jorendorff) → review+
Keywords: checkin-needed
Whiteboard: [c= p= s= u=] → [c= p=1 s= u=]
https://hg.mozilla.org/mozilla-central/rev/9c8ab7e9ae41
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.