927784 - [Messaging][Forward] Implement forward logic.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Given a message, we should be able to forward the message after tapping with a 'long press' and select this option from the list in the action menu.

Comment 1

[Rick Waldron [:rwaldron]]

Ok, didn't see this before I commented on #927783

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

blocking a committed 1.3 user story. 1.3+

Comment 3

[Rick Waldron [:rwaldron]]

(In reply to Borja Salguero [:borjasalguero] from comment #0)
> Given a message, we should be able to forward the message after tapping with
> a 'long press' and select this option from the list in the action menu.

Borja, do you mind if I re-assign this Evelyn (from Bocoup)?

Comment 4

[Borja Salguero [:borjasalguero]]

I have a patch working, only waiting to have the one which is blocking this one landed for delivering the patch, so I will follow with this work. Thanks for your support.

Comment 5

[Borja Salguero [:borjasalguero]]

Attachment: Pull request

Comment 6

[Rick Waldron [:rwaldron]]

(In reply to Borja Salguero [:borjasalguero] from comment #5)
> Created attachment 824063 [details]
> Pull request

I've made some comments. We need `ThreadUI.setMessageBody` to do the handling of setting message body (seems apt, right?) because Drafts will need this same operation and it should be duplicated. The easiest approach is to just change this (in message manager): 


  if (message.type === 'sms') {
    ThreadUI.setMessageBody(message.body);
  } else {
    SMIL.parse(message, function(parsedArray) {
      parsedArray.forEach(function(mmsElement) {
        if (!mmsElement.name) {
          Compose.append(mmsElement.text);
        } else {
          var attachment = new Attachment(mmsElement.blob, {
            name: mmsElement.name,
            isDraft: true
          });
          Compose.append(attachment);
          // Has the attachment any text associated?
          if (mmsElement.text) {
            Compose.append(mmsElement.text);
          }
        }
      });
    });

to this: 

  ThreadUI.setMessageBody(message);

And then upgrade ThreadUI.setMessageBody to:


  setMessageBody: function(value) {
    Compose.clear();

    if (value) {
      if (typeof value === 'string') {
        Compose.append(value);
      } else {
        if (value.type === 'sms') {
          Compose.append(value);
        } else {
          SMIL.parse(value, function(parsed) {
            parsed.forEach(function(mms) {
              if (!mms.name) {
                Compose.append(mms.text);
              } else {
                var attachment = new Attachment(mms.blob, {
                  name: mms.name,
                  isDraft: true
                });
                Compose.append(attachment);
                // Has the attachment any text associated?
                if (mms.text) {
                  Compose.append(mms.text);
                }
              }
            });
          });
        }      
      }
    }

    Compose.focus();
  }


This way Drafts can use the same mechanism

Comment 7

[Borja Salguero [:borjasalguero]]

Following https://github.com/mozilla-b2g/gaia/pull/13187#discussion_r7288349 I've just created a bug, https://bugzilla.mozilla.org/show_bug.cgi?id=932916, for adding this fix (due to it has implications in the current architecture, and it's needed for future features).

Comment 8

[Rick Waldron [:rwaldron]]

Two last nits on the PR, rebase and then r=me (looks like julienw was set as reviewer, I don't know if you want to wait for him to sign off on it)

Comment 9

[Borja Salguero [:borjasalguero]]

Hi Rick. I've just updated the code with the final nits and now it's rebased & squashed. Thanks for your quick review!

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 824063 [details]
Pull request

added comments on github
nothing big, should be easy to fix

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 824063 [details]
Pull request

r=me

thanks

let's wait for a green travis ?

Comment 12

[Borja Salguero [:borjasalguero]]

Rick, Do you have any other comment? If you think that this is r+, could you update the flag for ensuring that all comments are addressed? Thanks!

Comment 13

[Rick Waldron [:rwaldron]]

Comment on attachment 824063 [details]
Pull request

LGTM

Comment 14

[Julien Wajsberg [:julienw]]

master: b0cc3bf9fefe292f2dcbdd4ceba88c97ea700369