Closed Bug 927863 Opened 6 years ago Closed 6 years ago

Regression: Scrolling is broken inside frames

Categories

(Firefox for Android :: Toolbar, defect)

Product:
Firefox for Android
Component:
Toolbar
Version:
27 Branch
Platform:
All
Android
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 27
Tracking Flags:
Tracking Status
firefox26 --- unaffected
firefox27 --- verified

People

(Reporter: martijn.martijn, Assigned: kats)

References

(
URL
)

Details

(Keywords: regression, reproducible, testcase) 

See url testcase, you should be able to scroll the pages in the subframes.
This seems to fail in every (i)frame that I encountered.
This is a problem on trunk, but not in Aurora.

Tested on the Samsung Galaxy Nexus, Android 4.3.
I can repro as well. We need to get a regression range and back out the offending change, this seems pretty severe.
status-firefox26: --- → unaffected
status-firefox27: --- → affected
Thanks for the test-case Martijn.

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2013-09-30&enddate=2013-10-01

Kats, bug 911574?
tracking-fennec: --- → ?
Flags: in-testsuite?
Keywords: regressionwindow-wanted → reproducible
Hardware: Other → All
Summary: Scrolling is broken inside frames → Regression: Scrolling is broken inside frames
Version: unspecified → Firefox 27
Indeed. It appears that in iframes, it is the body and not the documentElement that has scrollTopMax > 0. I don't know why this is different from the root document.
Blocks: 911574
Fixed via backout of bug 911574.
Assignee: nobody → bugmail.mozilla
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox27: affected → fixed
Resolution: --- → FIXED
tn, do you know why for the top-level content document it is the root <html> element that is scrollable but for content iframes it is the <body> element?
Flags: needinfo?(tnikkel)
Just a guess but is the root content document in standards mode and the iframe document in quirks mode?

Element::GetScrollFrame at
http://mxr.mozilla.org/mozilla-central/source/content/base/src/Element.cpp#480 looks at the body in quirks mode and the html element in standards mode, and it is called from GetScrollTopMax.
Flags: needinfo?(tnikkel)
Target Milestone: --- → Firefox 27
Both the root frame and the iframe appear to be rendering in quirks mode in the desktop browser. I can try to dig into this a little more.
tracking-fennec: ? → ---
tracking-firefox27: ? → ---
Verified fixed on:
Build: Firefox for Android 27 Beta 2
Device: LG Nexus 4
OS: Android 4.2.2
status-firefox27: fixed → verified
You need to log in before you can comment on or make changes to this bug.