927999 - Feedback error messages need rewriting in proper English

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Francesco Lodolo [:flod]]

Changeset reference: http://hg.mozilla.org/releases/gaia-l10n/v1_2/en-US/rev/259c9c63dd13
Version: 1.2

feedback-error-connect-error=Sorry, because of data connection error. System can't send out your suggestion now. Please fix data connection problem and send again.
feedback-error-server-off=Sorry, because the server shutting down. System can't send out your suggestion now. Please wait a moment and send again.
feedback-error-timeout=Sorry, because time out. System can't send out your suggestion now. Please reboot and send again.
feedback-error-wrong-email=Sorry, because the email address is empty or format error. System can't send out your suggestion now. Please use correct email address and send again.
feedback-error-empty-comment=Sorry, because the comment field is empty. System can't send out your suggestion now. Please fill the form out and send again.
feedback-error-just-sent=Sorry, because you already sent us feedback. System can't send out your suggestion now. Please try our next software update and send again.

Beside the English, do we really have a "server shutting down"? Why in case of time out I need to reboot, in others just wait and retry?

To be honest this kind of errors should be catch during the review, before strings are exposed to localizers (now you need new IDs).

Comment 1

[Francesco Lodolo [:flod]]

Since it's in the same changeset, it would be useful to know if the space before ":" is really wanted

email-address=Email address :

Comment 2

[Matej Novak [:matej]]

Hi flod, thanks so much for catching these. Here are the updated strings:

feedback-error-connect-error=Sorry, the system can't send your suggestion due to a data connection error. Please try again when the issue is resolved.

feedback-error-server-off=Sorry, the system can't send your suggestion because the server shut down. Please wait a moment and try again.

feedback-error-timeout=Sorry, the system can't send your suggestion because of a timeout. Please restart and try again.

feedback-error-wrong-email=Sorry, the system can't send your suggestion because the email address is missing or due to a formatting error. Please use a valid email address and try again.

feedback-error-empty-comment=Sorry, the system can't send your suggestion because the comment field is empty. Please enter some text and try again.

feedback-error-just-sent=Sorry, the system can't send your suggestion because you already sent us feedback. Please try our next software update and send again.


Also, that extra space before the colon looks like a typo to me.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13004

Pointer to Github pull-request

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 820266 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13004

Since nobody seems interested, let's give it a try. Hope I understood how the js works, couldn't find anything better than email-address1 as a name.

If this patch is good we need it on 1.2 as well.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 820266 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/13004

Thank you for the effort! r=me.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominate for koi+ per comment 4 and the low risk of changing strings.

Comment 7

[Francesco Lodolo [:flod]]

Thanks Arthur, I'll need someone to merge this PR for me ;-)

Comment 8

[Bruce Huang [:bhuang] (inactive)]

triage: koi+ based on comment 6

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/1b53c7765693e812d7448de04bd1627cef6feb75

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 1b53c7765693e812d7448de04bd1627cef6feb75 to:
v1.2: b7eb8dab1807bad4368b4f62b61a6fb75cd139ea