9280 - Problems with relative URI's in RDF serialization

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I was getting very ugly things in RDF output like:
<RDF:li resource="file:///home/david/mozilla/david/appts.rdf#appt1"/>
when I really just would want
<RDF:li resource="#appt1"/>
and I looked at the serialization code to see whether there was an attempt to do
what I wanted, and found there was.  However, it isn't working for me right now,
I think because the 4 calls to mInner->GetURI() in nsRDFXMLDataSource.cpp are
returning null, so rdf_MakeRelativeRef wasn't doing much.  Changing
"mInner->GetURI" to "GetURI" worked for me, but I don't know if that's the
'right' way to fix this, or if this is a problem on platforms other than Linux,
etc., etc.:

1199c1199
<         mInner->GetURI(getter_Copies(docURI));
---
>         GetURI(getter_Copies(docURI));
1291c1291
<     rv = mInner->GetURI(getter_Copies(docURI));
---
>     rv = GetURI(getter_Copies(docURI));
1343c1343
<     mInner->GetURI(getter_Copies(docURI));
---
>     GetURI(getter_Copies(docURI));
1426c1426
<     mInner->GetURI( getter_Copies(docURI) );
---
>     GetURI( getter_Copies(docURI) );

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

FYI, you can use the test case from bug 9236, if you need one.  I'm seeing it
there, too.

Comment 2

[Chris Waterson]

Yes, this is absolutely the right thing to do. This is fallout from my sloppy
conversion to new APIs. I'll check these diffs in as soon as the tree opens.

Comment 3

[Chris Waterson]

Partial fix (what you suggested -- more or less) is checked in. There are still
some URL resolution snafus that I'll defer until M9 and the new URL resolution
code.

Leaving bug open, setting TM to M9.

Comment 4

[Chris Waterson]

Move to M10.

Comment 5

[Chris Waterson]

Marking fixed. Please scream if it's not.

Comment 6

[gerardok]

QA Contact massive update.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This has been working for ages.  I'm not sure what the cases were for which you
left it open when you fixed it, but I'm marking verified.