Add sign-up button to /teach page

RESOLVED FIXED

Status

Webmaker
webmaker.org
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: OpenMatt, Assigned: Zakeria Hassan)

Tracking

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
jbuck
: review+
inactivate account for kate
: review+
Details | Review | Splinter Review
* I know everyone's slammed with MozFest prep, but this is a request from Erica Sackin because we're getting a fair amount of attention from the "Hour of Code" project. Should be a quick fix. Doable?

Add sign-up button to /teach

1) Please add a button marked "Sign up" to the /teach page
https://webmaker.org/teach/

2) It can go directly to the right of the copy at the top of the page. To the right of "like you"

3) It links to this page:
https://sendto.mozilla.org/page/s/mentor-signup
(Reporter)

Updated

5 years ago
Severity: normal → major
(Assignee)

Comment 1

5 years ago
Hi,

Please assign this bug to me.

Thanks,
Zak
IRCNICK: Vader

Updated

5 years ago
Assignee: nobody → zak.hassan1010
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

Fixed bug please review.
Attachment #824997 - Flags: review?(jon)

Comment 3

5 years ago
Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

This doesn't look great: http://dl.dropbox.com/u/4403845/Screenshots/bh.png

:k88hudson - Maybe the button should go beside the "Discover the Web Literacy Standard" button?
Attachment #824997 - Flags: review?(kate)
Attachment #824997 - Flags: review?(jon)
Attachment #824997 - Flags: review-
(Assignee)

Comment 4

5 years ago
Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

@jon:
I moved the button to the right side of the 'discovery' button. Please review.
Attachment #824997 - Flags: review- → review?(jon)
Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

Please use HTML5 syntax. Other than that, this should be good
Attachment #824997 - Flags: review?(kate) → review-

Comment 6

5 years ago
Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

Looks good to me, just fix up Kate's nits noted in the PR
Attachment #824997 - Flags: review?(jon) → review+
(Assignee)

Comment 7

5 years ago
@k88hudson

I will fixed this. I ran the following command to see if others made the same mistake. I thought it would be good for me to share this with you.

 $ git grep -n "<br />"| awk '{print $1}'| sed 's/:/ found <br \/> on line ->  /'| sed 's/{%//'| sed 's/://'

locale/bn_BD/webmaker.org.json found <br /> on line ->  22
locale/bn_IN/webmaker.org.json found <br /> on line ->  22
locale/en_CA/webmaker.org.json found <br /> on line ->  22
locale/en_CA/webmaker.org.json found <br /> on line ->  175
locale/en_CA/webmaker.org.json found <br /> on line ->  357
locale/en_US/webmaker.org.json found <br /> on line ->  403
locale/en_US/webmaker.org.json found <br /> on line ->  432
locale/es/webmaker.org.json found <br /> on line ->  22
locale/fr/webmaker.org.json found <br /> on line ->  22
locale/pt/webmaker.org.json found <br /> on line ->  22
locale/ru/webmaker.org.json found <br /> on line ->  22
locale/th_TH/webmaker.org.json found <br /> on line ->  22
views/events/details.html found <br /> on line ->  112
views/events/map.html found <br /> on line ->  49
views/events/map.html found <br /> on line ->  59
views/events/map.html found <br /> on line ->  72
views/teach.html found <br /> on line ->  10
(Assignee)

Comment 8

5 years ago
I've rebased and fixed all mistakes. Please review when you get a chance.

Thanks,
Zak
(Assignee)

Updated

5 years ago
Attachment #824997 - Flags: review- → review?(kate)
Attachment #824997 - Flags: review?(kate) → review+
(Assignee)

Comment 9

5 years ago
Since this bug has been reviewed and given a review+. Lets set this to resolved.

Thanks,
Zak
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(matt)
Resolution: --- → WORKSFORME
Looks like this needs to be landed first still.

Also, OpenMatt can't help you land this :)
Flags: needinfo?(matt)
(Assignee)

Comment 11

5 years ago
@mjschranz

Could you land this ?
Not right now.

Also, apparently my need infos didn't set!
Flags: needinfo?(kate)
Flags: needinfo?(jon)

Updated

5 years ago
Resolution: WORKSFORME → FIXED
Thanks for the patch Zakeria!
Flags: needinfo?(kate)
Flags: needinfo?(jon)
You need to log in before you can comment on or make changes to this bug.