928090 - Add sign-up button to /teach page

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Matt Thompson (@OpenMatt :OpenMatt)]

* I know everyone's slammed with MozFest prep, but this is a request from Erica Sackin because we're getting a fair amount of attention from the "Hour of Code" project. Should be a quick fix. Doable?

Add sign-up button to /teach

1) Please add a button marked "Sign up" to the /teach page
https://webmaker.org/teach/

2) It can go directly to the right of the copy at the top of the page. To the right of "like you"

3) It links to this page:
https://sendto.mozilla.org/page/s/mentor-signup

Comment 1

[Zakeria Hassan]

Hi,

Please assign this bug to me.

Thanks,
Zak
IRCNICK: Vader

Comment 2

[Zakeria Hassan]

Attachment: https://github.com/mozilla/webmaker.org/pull/477

Fixed bug please review.

Comment 3

[Jon Buckley [:jbuck]]

Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

This doesn't look great: http://dl.dropbox.com/u/4403845/Screenshots/bh.png

:k88hudson - Maybe the button should go beside the "Discover the Web Literacy Standard" button?

Comment 4

[Zakeria Hassan]

Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

@jon:
I moved the button to the right side of the 'discovery' button. Please review.

Comment 5

[inactivate account for kate]

Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

Please use HTML5 syntax. Other than that, this should be good

Comment 6

[Jon Buckley [:jbuck]]

Comment on attachment 824997 [details] [review]
https://github.com/mozilla/webmaker.org/pull/477

Looks good to me, just fix up Kate's nits noted in the PR

Comment 7

[Zakeria Hassan]

@k88hudson

I will fixed this. I ran the following command to see if others made the same mistake. I thought it would be good for me to share this with you.

 $ git grep -n "<br />"| awk '{print $1}'| sed 's/:/ found <br \/> on line ->  /'| sed 's/{%//'| sed 's/://'

locale/bn_BD/webmaker.org.json found <br /> on line ->  22
locale/bn_IN/webmaker.org.json found <br /> on line ->  22
locale/en_CA/webmaker.org.json found <br /> on line ->  22
locale/en_CA/webmaker.org.json found <br /> on line ->  175
locale/en_CA/webmaker.org.json found <br /> on line ->  357
locale/en_US/webmaker.org.json found <br /> on line ->  403
locale/en_US/webmaker.org.json found <br /> on line ->  432
locale/es/webmaker.org.json found <br /> on line ->  22
locale/fr/webmaker.org.json found <br /> on line ->  22
locale/pt/webmaker.org.json found <br /> on line ->  22
locale/ru/webmaker.org.json found <br /> on line ->  22
locale/th_TH/webmaker.org.json found <br /> on line ->  22
views/events/details.html found <br /> on line ->  112
views/events/map.html found <br /> on line ->  49
views/events/map.html found <br /> on line ->  59
views/events/map.html found <br /> on line ->  72
views/teach.html found <br /> on line ->  10

Comment 8

[Zakeria Hassan]

I've rebased and fixed all mistakes. Please review when you get a chance.

Thanks,
Zak

Comment 9

[Zakeria Hassan]

Since this bug has been reviewed and given a review+. Lets set this to resolved.

Thanks,
Zak

Comment 10

[Matthew Schranz [:mjschranz]]

Looks like this needs to be landed first still.

Also, OpenMatt can't help you land this :)

Comment 11

[Zakeria Hassan]

@mjschranz

Could you land this ?

Comment 12

[Matthew Schranz [:mjschranz]]

Not right now.

Also, apparently my need infos didn't set!

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/44a073f2cc2eed084fb239c0b257e976c2495405
Fix bug 928090 - Added sign-up button to /teach page

Comment 14

[Jon Buckley [:jbuck]]

Thanks for the patch Zakeria!