Build: 10/17/2013 Master Leo STR 1. Setup your build according to https://wiki.mozilla.org/B2G/QA/Customizations#Build_Setup with an AT&T US SIM Expected When the phone power on customization renders, no app install notification toast should appear. Actual When the phone power on customization renders, an app install notification toast appears for one of the apps preinstalled.
Can UX comment here if this is a blocker for 1.2 or not? This kinda makes the first power on of the device seem off, as we're showing a toast that doesn't need to be there. This issue wasn't present in the 1.1 & 1.01 timeframes with apps customizations without variant customizations either. From an end user perspective, this would likely be perceived as a regression.
I don't know if that's really a bug. From my point of view, the fact that the app installation message is shown is good, since it informs the user of the apps that are installed as part of/because of his operator choice. On 1.0.1. and 1.1 no apps were installed at boot time (they were all installed at build time), that's why there was no message. In any case, for a user to notice that he would have to have both a 1.0.1/1.1 device and a brand new device with 1.2 installed (since the FOTAs won't carry operator single variant apps). In any case, once UX says if this is a desirable behavior or not I can take this bug
(In reply to Carmen Jimenez Cabezas from comment #2) > I don't know if that's really a bug. > From my point of view, the fact that the app installation message is shown > is good, since it informs the user of the apps that are installed as part > of/because of his operator choice. I disagree with this. If you are first launching your phone for the first time, a user going to be really confused why this is showing up. If we were adding the apps after the fact (e.g. SIM inserted post FTE and restart of phone), then I still think a little bit odd to put in power on animation. What would likely make more sense would be display some explicit notification when the homescreen first displays.
I agree with Jason here. No banners (related to background app installation; others may apply) should appear while the user is going through the FTE. The ideal scenario would be that the user finishes FTE and lands on the homescreen with whatever additional apps already there. There's no need for further information; this is the brand new phone as intended and perhaps even advertised (say, a partnership with a music service or something like that).
Removing ni? for UX since Rafa addressed this sufficiently, and because UX works with him closely.
Created attachment 822820 [details] [review] This fixes the described problem by not showing any installation notification during the FTU
Comment on attachment 822820 [details] [review] This fixes the described problem by not showing any installation notification during the FTU Looks good to me, but you'll need Etienne's or Julien's r+ as I am not a peer of this code.
Comment on attachment 822820 [details] [review] This fixes the described problem by not showing any installation notification during the FTU Comments on github! Please ping me if you need any help with sinon fake timers. You can find inspiration here: https://github.com/mozilla-b2g/gaia/blob/master/apps/system/test/unit/update_manager_test.js
I updated the PR with the changes requested. Can you take another look at it?
I'm really sorry I didn't catch this earlier, but the code involved is actually synchronous so we don't need the `TINY_TIMEOUT` nor the fake timers at all! Otherwise this patch is good to go, so we just need to remove the fake timers.
I have changed what you requested. Can I ask for checkin with r=you, Etienne?
Comment on attachment 822820 [details] [review] This fixes the described problem by not showing any installation notification during the FTU All good, congrats! :)
This is fixed, but isn't uplifted for 1.2. Is this a blocker for 1.2 finally, or is UX ok with 1.2 showing the toasts for the apps installation?
Uplifted 72758c49ea3097b72a121578b193e54dc95e22cd to: v1.2: 6342dbd8eb0c9cdf613741de01b9b1c8cb19a48d
No install success notification appears when following the provided steps. 1.2 Environmental Variables: Device: Buri v1.2 COM RIL BuildID: 20131205004003 Gaia: 0659f16b9790b1cf9eba4d80743fcc774d2ffe3a Gecko: af2c7ebb5967 RIL Version: 01.02.00.019.102 Version: 26.0 Firmware Version: V1.2_20131115
Removing Verifyme tag due to comment 18.