928223 - [Wifi][WPA-EAP] wpa_supplicant can't access keystore socket due to lack of R/W permission.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

keystore socket is created with permission 750 and owner root:root, but wpa_supplicant is run as user wifi.
Hence we need change it's permission to 666.

Comment 1

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add function to perform setup for listen socket.

Add new function to unixsocket ipc to perform setup for listen sockets, per bug 789217 comment 34.
ril, bluetooth, and nfc are affected.

Comment 2

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Change keystore socket permission after created.

Change socket permission after it is created.

Comment 3

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Run try to make sure current patch can be built on all platform: https://tbpl.mozilla.org/?tree=Try&rev=768dc082c035

Comment 4

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Thanks for doing this! Always figured we'd need more granularity in UnixSocket, just didn't know where it'd be needed. :)

Comment 5

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add function to perform setup for listen socket.

Update reviewer in commit summary.

Comment 6

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Change keystore socket permission after created.

Update reviewer in commit summary.

Comment 7

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Try befor check in : https://tbpl.mozilla.org/?tree=Try&rev=ffbf246e5690

Comment 8

[Ed Morley [:emorley]]

Please can you rebase? :-)

[/c/src-gecko/b2g-inbound]$ qimp 928223
Fetching... done
Parsing... done
1: 0001. Add function to perform setup for listen socket.
2: 0002. Change keystore socket permission after created.
Which patches do you want to import? [Default is '1', use '1-2' for all] 1-2
adding 928223 to series file
renamed 928223 -> 0002._Change_keystore_socket_permission_after_created.patch
adding 0001._Add_function_to_perform_setup_for_listen_socket.patch to series file
applying 0001._Add_function_to_perform_setup_for_listen_socket.patch
patching file dom/bluetooth/BluetoothUnixSocketConnector.cpp
Hunk #1 FAILED at 155
1 out of 1 hunks FAILED -- saving rejects to file dom/bluetooth/BluetoothUnixSocketConnector.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 0001._Add_function_to_perform_setup_for_listen_socket.patch

Comment 9

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0001. Add function to perform setup for listen socket.

Rebase.

Comment 10

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Attachment: 0002. Change keystore socket permission after created.

Rebase.

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c5a70830dc9a
https://hg.mozilla.org/integration/b2g-inbound/rev/d2fed8417957

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c5a70830dc9a
https://hg.mozilla.org/mozilla-central/rev/d2fed8417957