928281 - [Gaia] Set keyboard iframe attribute "remote=true" for keyboard OOP

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #816874 +++

This is a Gaia change to modify "remote=true" for the keyboard frame when loading 3rd-party keyboard app.

** For triage **
This is for keyboard OOP, so nominate it as koi+.

Comment 1

[Ivan Tsay (:ITsay)]

(In reply to Rudy Lu [:rudyl] from comment #0)
> +++ This bug was initially created as a clone of Bug #816874 +++
> 
> This is a Gaia change to modify "remote=true" for the keyboard frame when
> loading 3rd-party keyboard app.
> 
> ** For triage **
> This is for keyboard OOP, so nominate it as koi+.

Plus it based on the comments

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

We already have a patch to activate this, but are waiting for Bug 847763 to land.

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: pull request 13115

As an offline discussion, we want to add a setting entry to enable keyboard OOP first so that it would be easy to test Gecko patch.

This setting entry will need to be removed before shipping.

--
Tim, could you help review this?
Thanks.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 822774 [details] [review]
pull request 13115

Thanks!

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master:
https://github.com/mozilla-b2g/gaia/commit/9c6586d85d4340600ace0aa69f5741c5f3f67970

--
Tim, thanks for the quick review.

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Backed out with Bug 912010 with this commit,
90fbd75eccd3408ca04907fd80b72275771b3b30

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

relanded in 5441c37b27ed6220ca0545c576e4d26c2ecf4ca3

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Reverted: https://github.com/mozilla-b2g/gaia/commit/4fd4b736c967cdf4456e1f7664c75a466ffe34f2

Comment 9

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Relanded with this commit,
https://github.com/mozilla-b2g/gaia/commit/5441c37b27ed6220ca0545c576e4d26c2ecf4ca3

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Rudy Lu [:rudyl] from comment #9)
> Relanded with this commit,
> https://github.com/mozilla-b2g/gaia/commit/
> 5441c37b27ed6220ca0545c576e4d26c2ecf4ca3

Correction: not reland, commit in comment 8 was not pushed to gaia master.

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x  5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

This was uplifted in 90d2ede..cce2ba1

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.2 reverted: 9d335a436d494c3703e98e195c6d94da4be9a15d

https://tbpl-dev.allizom.org/?rev=fc1043ab2d67&tree=Mozilla-B2g26-v1.2

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.2 reland: e717aec947571f5daf923c040a82f9f0719bb526

Let's see if we could isolate the issue.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sorry, wrong bug. Please ignore comment 14.

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.2 reland: 9e4c9a71c93620c6529a904ee16b745d570e4a9e

Comment 17

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.2 revert #2: 9e4c9a71c93620c6529a904ee16b745d570e4a9e

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Correction,

v1.2 revert #2: 9bdd41c3dea84905ad93d02dfa36f92757ea1ada

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

See bug 933718. It seems that this bug is not the cause of TBPL fail. We should re-land the bug once the tree is open.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.2 reland #2: 2e5dc6b9600bf2bc2ff3fc359120e2883ef50e38