Closed Bug 928281 Opened 11 years ago Closed 11 years ago

[Gaia] Set keyboard iframe attribute "remote=true" for keyboard OOP

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Keyboard
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Milestone:
1.2 C4(Nov8)
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: rudyl, Assigned: rudyl)

References

Details

(Whiteboard: [3rd-party-keyboard])

Attachments

(1 file)

pull request 13115
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review 
+++ This bug was initially created as a clone of Bug #816874 +++

This is a Gaia change to modify "remote=true" for the keyboard frame when loading 3rd-party keyboard app.

** For triage **
This is for keyboard OOP, so nominate it as koi+.
(In reply to Rudy Lu [:rudyl] from comment #0)
> +++ This bug was initially created as a clone of Bug #816874 +++
> 
> This is a Gaia change to modify "remote=true" for the keyboard frame when
> loading 3rd-party keyboard app.
> 
> ** For triage **
> This is for keyboard OOP, so nominate it as koi+.

Plus it based on the comments
blocking-b2g: koi? → koi+
Target Milestone: --- → 1.2 C4(Nov8)
Assignee: nobody → gchen
We already have a patch to activate this, but are waiting for Bug 847763 to land.
Assignee: gchen → rlu
Whiteboard: [3rd-party-keyboard]
Attached file pull request 13115 — 
As an offline discussion, we want to add a setting entry to enable keyboard OOP first so that it would be easy to test Gecko patch.

This setting entry will need to be removed before shipping.

--
Tim, could you help review this?
Thanks.
Attachment #822774 - Flags: review?(timdream)
Comment on attachment 822774 [details] [review]
pull request 13115

Thanks!
Attachment #822774 - Flags: review?(timdream) → review+
Landed to Gaia master:
https://github.com/mozilla-b2g/gaia/commit/9c6586d85d4340600ace0aa69f5741c5f3f67970

--
Tim, thanks for the quick review.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Backed out with Bug 912010 with this commit,
90fbd75eccd3408ca04907fd80b72275771b3b30
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
relanded in 5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Relanded with this commit,
https://github.com/mozilla-b2g/gaia/commit/5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
(In reply to Rudy Lu [:rudyl] from comment #9)
> Relanded with this commit,
> https://github.com/mozilla-b2g/gaia/commit/
> 5441c37b27ed6220ca0545c576e4d26c2ecf4ca3

Correction: not reland, commit in comment 8 was not pushed to gaia master.
Depends on: 912010
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x  5441c37b27ed6220ca0545c576e4d26c2ecf4ca3
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(rlu)
This was uplifted in 90d2ede..cce2ba1
status-b2g-v1.2: --- → fixed
Flags: needinfo?(rlu)
v1.2 reland: e717aec947571f5daf923c040a82f9f0719bb526

Let's see if we could isolate the issue.
Sorry, wrong bug. Please ignore comment 14.
v1.2 reland: 9e4c9a71c93620c6529a904ee16b745d570e4a9e
status-b2g-v1.2: affected → fixed
v1.2 revert #2: 9e4c9a71c93620c6529a904ee16b745d570e4a9e
Correction,

v1.2 revert #2: 9bdd41c3dea84905ad93d02dfa36f92757ea1ada
status-b2g-v1.2: fixed → affected
See bug 933718. It seems that this bug is not the cause of TBPL fail. We should re-land the bug once the tree is open.
v1.2 reland #2: 2e5dc6b9600bf2bc2ff3fc359120e2883ef50e38
status-b2g-v1.2: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: