Closed Bug 928304 Opened 6 years ago Closed 6 years ago

mozRTCIceCandidate could use jsonifier to simplify passing the ice candidate via signalling

Categories

(Core :: WebRTC, defect)

ARM
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Currently if I take a mozRTCIceCandidate and try to pass that to a peer via a signalling server, I end up with an empty object.

This is different to mozRTCSessionDescription which automatically gives me an object that can be translated into json.

Currently the webidl for mozRTCIceCandidate points to bug 863402, but it seems that is not really needed if jsonifer is used as per the current mozRTCSessionDescription implementation.
Blocks: Talkilla
This adds the jsonifier attribute which magically gives us the toJSON() functionality we need.

Also included is a testcase for this, based on the one for session descriptions.
Assignee: nobody → mbanner
Status: NEW → ASSIGNED
Attachment #819706 - Flags: review?(rjesup)
Comment on attachment 819706 [details] [diff] [review]
Add jsonifier attribute

Review of attachment 819706 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me, but reassigning to jib for review
Attachment #819706 - Flags: review?(rjesup) → review?(jib)
Comment on attachment 819706 [details] [diff] [review]
Add jsonifier attribute

Review of attachment 819706 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm too. Thanks.
Attachment #819706 - Flags: review?(jib) → review+
https://hg.mozilla.org/mozilla-central/rev/2f50c6ff8124
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.