928304 - mozRTCIceCandidate could use jsonifier to simplify passing the ice candidate via signalling

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Mark Banner (:standard8)]

Currently if I take a mozRTCIceCandidate and try to pass that to a peer via a signalling server, I end up with an empty object.

This is different to mozRTCSessionDescription which automatically gives me an object that can be translated into json.

Currently the webidl for mozRTCIceCandidate points to bug 863402, but it seems that is not really needed if jsonifer is used as per the current mozRTCSessionDescription implementation.

Comment 1

[Mark Banner (:standard8)]

Attachment: Add jsonifier attribute

This adds the jsonifier attribute which magically gives us the toJSON() functionality we need.

Also included is a testcase for this, based on the one for session descriptions.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 819706 [details] [diff] [review]
Add jsonifier attribute

Review of attachment 819706 [details] [diff] [review]:
-----------------------------------------------------------------

Looks ok to me, but reassigning to jib for review

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 819706 [details] [diff] [review]
Add jsonifier attribute

Review of attachment 819706 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm too. Thanks.

Comment 4

[Mark Banner (:standard8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2f50c6ff8124

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2f50c6ff8124

Comment 6

[Eric Shepherd [:sheppy]]

Docs added:

https://developer.mozilla.org/en-US/docs/Web/API/RTCIceCandidate/toJSON

Docs updated:

https://developer.mozilla.org/en-US/Firefox/Releases/27

BCD for RTCIceCandidate also updated.