Closed
Bug 928464
Opened 11 years ago
Closed 11 years ago
Handle array/object initializers in 'new' scripts
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 928562
People
(Reporter: bhackett1024, Unassigned)
References
Details
Attachments
(1 file)
7.63 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
This is a regression from bug 922270, when we run the definite properties analysis on a script it has usually not been baseline compiled, and we end up aborting the analysis if template objects can't be obtained from newarray or newobject operations in the script.
Attachment #819117 -
Flags: review?(jdemooij)
Comment 1•11 years ago
|
||
Comment on attachment 819117 [details] [diff] [review] patch Review of attachment 819117 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jit/IonBuilder.cpp @@ +5439,5 @@ > bool needStub = false; > + if (!obj->resultTypeSet() || obj->resultTypeSet()->unknownObject()) { > + needStub = true; > + } else { > + types::TypeObjectKey *initializer = obj->resultTypeSet()->getObject(0); Pre-existing, but can we assert getObjectCount() == 1 here? @@ +5515,4 @@ > > RootedObject templateObject(cx, obj->toNewObject()->templateObject()); > > if (!CanEffectlesslyCallLookupGenericOnObject(cx, templateObject, name)) Can you move this call inside the "if (templateObject)" below? CanEffectlesslyCallLookupGenericOnObject currently returns |true| if templateObject == nullptr so there's not really a problem atm but better to avoid the call in that case.
Attachment #819117 -
Flags: review?(jdemooij) → review+
Reporter | ||
Comment 2•11 years ago
|
||
Actually, I think it'd be better to just wait for bug 928562 for this fix. That bug reworks things a bit so that we baseline compile the script before the definite properties analysis (so that BytecodeTypes works) which will make these template objects available to IonBuilder.
Depends on: 928562
Reporter | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•