Closed Bug 928545 Opened 11 years ago Closed 11 years ago

confusing l10n around deleting payments

Categories

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Product:
Marketplace Graveyard
Component:
Payments/Refunds
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-10-28

People

(Reporter: clouserw, Assigned: davidbgk)

Details

(Whiteboard: kanbanzilla[Review]) 

https://github.com/mozilla/zamboni/blob/master/media/js/devreg/payments-manage.js#L23 came up on the dev-l10n-web mailing list.  We can't just have stuff like ngettext('it').  Without context people won't be able to localize.  This should be replaced with something else like:

> Deleting payment account "{0}" will mark the following as incomplete:


Actually, looking at it, is the string even localized?  I don't think we pick up on format() do we?
Version: 1.5 → 1.4
This is missing gettext() so, yes, it is not localized. However, you can't localize plural forms the way this coder wants to. You have to list each plural localization separately, like:

format(ngettext('this is the singular sentence. App: {0}', 'this is the plural sentence. App: {0}', isPlural), [data['name']])
Priority: -- → P3
Target Milestone: --- → 2013-10-28
Whiteboard: kanbanzilla[Review]
https://github.com/mozilla/zamboni/commit/9673593cfb3ce71d022defbce04f6cbc50fbec3a
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.