928545 - confusing l10n around deleting payments

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Wil Clouser [:clouserw]]

https://github.com/mozilla/zamboni/blob/master/media/js/devreg/payments-manage.js#L23 came up on the dev-l10n-web mailing list.  We can't just have stuff like ngettext('it').  Without context people won't be able to localize.  This should be replaced with something else like:

> Deleting payment account "{0}" will mark the following as incomplete:


Actually, looking at it, is the string even localized?  I don't think we pick up on format() do we?

Comment 1

[Kumar McMillan [:kumar]]

This is missing gettext() so, yes, it is not localized. However, you can't localize plural forms the way this coder wants to. You have to list each plural localization separately, like:

format(ngettext('this is the singular sentence. App: {0}', 'this is the plural sentence. App: {0}', isPlural), [data['name']])

Comment 2

[David Larlet [:davidbgk]]

https://github.com/mozilla/zamboni/pull/1282

Comment 3

[David Larlet [:davidbgk]]

https://github.com/mozilla/zamboni/commit/9673593cfb3ce71d022defbce04f6cbc50fbec3a