928626 - Nightly doesn't restore the opened tabs of the previous session with FBTrace enabled

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[Florent Fayolle]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131019030204

Steps to reproduce:

1. Open Nightly 27
2. Open some webpages (new tabs, etc)
3. Restart


Actual results:

Nightly doesn't restore the previously opened tabs.

Note: I saw that in "Settings" => "General", the "When Nightly starts" option had been reset to "Show my home page". I have set it back to "show my windows and tabs from the last time", but that doesn't solve the issue.

Florent

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

No problem here on win7 x64 Nightly m-c builds.  I have 'show my home page' selected and all works here.

Make sure your not in Private Browsing, and that your NOT clearing history on shut-down.

Comment 2

[Florent Fayolle]

Attachment: privacy preferences

Comment 3

[Florent Fayolle]

> I have 'show my home page' selected and all works here.
Well, what I want is "Show my windows and tabs from the last time".

> Make sure your not in Private Browsing, and that your NOT clearing history on shut-down.
Well, no. I attach the screenshot of my "preference" => "privacy" tab.

Florent

Comment 4

[Manuela Muntean [Away]]

Florent, could you please try the following, to see if you still reproduce the issue :

1) try this with a clean profile: http://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

2) running in Safe mode: http://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Comment 5

[Florent Fayolle]

> 1) try this with a clean profile: http://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

I don't encounter the issue with a new profile. 

Could a diff of the prefs.js files be helpful?

Florent

Comment 6

[Florent Fayolle]

Okay, I got the cause: this is due to FBTrace, which is a tool used to develop on Firebug:
http://code.google.com/p/fbug/issues/detail?id=6881

Preventing the FBTrace window from being opened at launch just makes me have this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=928630

Florent

Comment 7

[Clochix]

I just noticed this could be related to bug 928630 : my browser just crashed. On restart, it opened the restore-session page, and the about:home in the same tab. So I thought it has lost my session. Fortunately, I noticed the back button was enabled, clicked on it and was able to restore my previous session. If I didn't noticed the back button, I would have thought my session was last.
So this is maybe related…

Comment 8

[Sebastian Zartner [:sebo]]

The fix for bug 928630 didn't fix this issue yet. The session still isn't restored correctly when restarting via FBTrace.
Btw. the code FBTrace uses for restarting is located on GitHub.[1]

Sebastian

[1] https://github.com/firebug/firebug/blob/b5c60404366d9aa6e4035cd0f7fec596d5ad16e5/trace/FBTrace/chrome/content/traceConsole.js#L340

Comment 9

[Wayne Mery (:wsmwk)]

So, is this really a problem with Firefox that deserves the bug being changed to NEW?  
Or, is FBtrace doing bad things that it shouldn't be doing and Fx is behaving properly??

Comment 10

[Sebastian Zartner [:sebo]]

Actually, this bug isn't reproducible anymore using Firefox 50.0a1 (2016-07-24) + FBTrace 3.0b2 on Windows 7. Therefore I close this bug now.
Florent, if you can still reproduce it, feel free to reopen it.

FWIW here's the related code:
https://github.com/firebug/tracing-console/blob/9a75be467fbb2d0f41dd58b0dce32dc421343462/chrome/content/traceConsole.js#L341-L355

Sebastian