Closed Bug 928632 Opened 6 years ago Closed 6 years ago

When the birth year is empty, SeaMonkey puts 1900 and in English language

Categories

(SeaMonkey :: MailNews: Address Book & Contacts, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.30

People

(Reporter: iann_bugzilla, Assigned: ewong)

References

Details

Attachments

(1 file, 2 obsolete files)

+++ This bug was initially created as a clone of Bug #544315 +++

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.9.2) Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.9.1.7) Gecko/20100111 Lightning/1.0b1 Thunderbird/3.0.1

When the year of born is empty, thunderbird put 1900 and in english language, my TB is in spanish. Also, it should show as "born date", not birth date.
Example: I borned on monday, but my  birth date day is (this year) on sunday

Reproducible: Always

Steps to Reproduce:
1.Put in the date of birthdate
2.Leave empty the year (or age)
3. OK
Actual Results:  
thunderbird put 1900 and in english language (the day name)
Also, it should show as "born date", not birth date

Expected Results:  
Leave in blank the year, display only day and month, and in the language of thunderbird.
(In reply to Ian Neal from comment #0)
> +++ This bug was initially created as a clone of Bug #544315 +++
> 
> User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR; rv:1.9.2)
> Gecko/20100115 Firefox/3.6 (.NET CLR 3.5.30729)
> Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; es-AR;
> rv:1.9.1.7) Gecko/20100111 Lightning/1.0b1 Thunderbird/3.0.1
> 
> When the year of born is empty, thunderbird put 1900 and in english
> language, my TB is in spanish. Also, it should show as "born date", not
> birth date.
> Example: I borned on monday, but my  birth date day is (this year) on sunday
-------------^^^^^^
I was born, you were born. Since you (Möbius, reporter of bug 544315, with an email address in .ar) are correcting (below) Thunderbird's English language, let me tell you that "borned" is a barbarism. "Born" is not an infinitive, it's the past participle of the verb "to bear", used here in its archaic sense of "to be pregnant with" or (in perfect, like here) "to give birth to". No offense meant, of course: I understand that your native language is Spanish, not English.
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> 1.Put in the date of birthdate
> 2.Leave empty the year (or age)
> 3. OK
> Actual Results:  
> thunderbird put 1900 and in english language (the day name)
> Also, it should show as "born date", not birth date

"Birth date" is the correct expression in English for the time when you were born, including the year. "Born date" is not used. The same day every year is the "birthday", as in "Happhy birthday to you!".

Similarly in French: "Date de naissance" vs. "Anniversaire". In Spanish it may be different, I don't know.

> 
> Expected Results:  
> Leave in blank the year, display only day and month, and in the language of
> thunderbird.
(In reply to Tony Mechelynck [:tonymec] from comment #1)
> "Birth date" is the correct expression in English for the time when you were
> born, including the year. "Born date" is not used. The same day every year
> is the "birthday", as in "Happhy birthday to you!".

I see "Birthday" in my SeaMonkey's Address Book card, which looks perfectly fine, though it can show up with a specific year (in which case it's rather "Date of Birth" as in official documents) or without ay year (the "Birthday" - currently broken on Windows). I've never seen "Born date" being used in any context.
I have created another bug to spin out the l10n issue.  Please refer to bug 928932.
Depends on: 928932
(In reply to Ian Neal from comment #0)
> Leave in blank the year, display only day and month, and in the language of
> thunderbird.

As stated in another bug, a *conventional* way to display (month) is to follow underlying O/S regional setting instead of Thunderbird (localized) language.

* In other words, if a user wants to display months in Spanish, he should modify regional settings from the O/S to match Spanish.
As stated in bug 928932, comment #5, changing "Birthday" to "Date of birth" would work when translated to Spanish whether the year is provided or not.
Attached patch Proposted patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #8337186 - Flags: review?(neil)
(In reply to Ricardo Palomares from comment #6)
> As stated in bug 928932, comment #5, changing "Birthday" to "Date of birth"
> would work when translated to Spanish whether the year is provided or not.

As I have stated in comment #4, please go to bug 928932 for all Spanish related problem, OK?
(In reply to Edmund Wong (:ewong) from comment #7)
> Created attachment 8337186 [details] [diff] [review]
> Proposted patch (v1)

Thx.  Your suggested patch is for Seamonkey.  There's a similar suggested patch in bug 544315 for Thunderbird.  Maybe you could try to match the same style as the other one?
Comment on attachment 8337186 [details] [diff] [review]
Proposted patch (v1)

>-<!ENTITY Birthday.label                 "Birthday:">
>-<!ENTITY Birthday.accesskey             "B">
>+<!ENTITY DateOfBirth.label              "Date of Birth:">
>+<!ENTITY DateOfbirth.accesskey          "B">
Don't change this, that's a separate bug. r=me on the %e => %d change.
Attachment #8337186 - Flags: review?(neil) → review+
Interestingly %e aborts my debug build (presumably I'm using the debug CRT though).

(In reply to Seak, Teng-Fong from comment #9)
> Your suggested patch is for Seamonkey.  There's a similar suggested
> patch in bug 544315 for Thunderbird.  Maybe you could try to match the same
> style as the other one?

I prefer the style of this patch. (I'm unsure why the other patch used 5 lines when one would do.)
(In reply to neil@parkwaycc.co.uk from comment #11)
> 
> I prefer the style of this patch. (I'm unsure why the other patch [in bug 544315] used 5
> lines when one would do.)

I'm not sure what 5 lines vs 1 line you're talking about (which file at which line?)
But if 5 lines are necessary to assure maintainability, quality, readability, etc for the code, why not?  It's not a competition to have the least lines of codes.

If a program is made by one person and if he is the only one supposed to change the code all the time (up to the program's end of life), then I agree that he has the right to use the least line of code or whatever he likes.  But Mozilla is maintained by the whole Internet community, so the most important thing upon a change is to make sure others can understand the code being changed.
Attached patch proposed patch (v2) (obsolete) — Splinter Review
Attachment #8337186 - Attachment is obsolete: true
Attachment #8349918 - Flags: review+
This has checked in for Thunderbird, comm-central changeset 88420197ae6b
Comment on attachment 8349918 [details] [diff] [review]
proposed patch (v2)

> ## LOCALIZATION NOTE (dateformat)
As with the TB patch, this needs to be changed to be dateFormatMonthDay

> ## Only used if the year isn't present and should be in the format used by Date.toLocaleFormat
> ## see http://developer.mozilla.org/en/Core_JavaScript_1.5_Reference/Global_Objects/Date/toLocaleFormat
>-## %B is the month's localized name and %e is the day of the month [1-31]
>+## %B is the month's localized name and %d is the day of the month [1-31].
Shouldn't this say [01-31]. like the TB patch?

>-      // if the year doesn't exist, display Month DD (ex. January 01)
>+      // if the year doesn't exist, display Month DD (ex. January 1)
This comment was correct before you changed it i.e. January 01
Attachment #8349918 - Attachment is obsolete: true
Attachment #8401102 - Flags: review+
Attachment #8401102 - Flags: review+ → review?(neil)
Attachment #8401102 - Flags: review?(neil) → review+
Blocks: 928932
No longer depends on: 928932
Pushed to comm-central:
https://hg.mozilla.org/comm-central/rev/f28724f7c52d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.30
You need to log in before you can comment on or make changes to this bug.