928671 - Respect browser.urlbar.trimURLs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Tom S. (please needinfo tschuster)]

Attachment: trim-android

Somebody on reddit was asking about this (http://www.reddit.com/r/firefox/comments/1osqyw/firefox_24_android_address_url_wonder_bar_we_they/) and it seemed to be quite easy to implement.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 819400 [details] [diff] [review]
trim-android

Review of attachment 819400 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/BrowserToolbar.java
@@ +238,5 @@
>                  });
>              }
>  
>              @Override
> +            public void prefValue(String pref, boolean value) {

If you're not going to explicitly check the pref, lets at least add a comment to both of these methods about what pref they're handling.

@@ +249,5 @@
> +                    @Override
> +                    public void run() {
> +                        updateTitle();
> +                    }
> +                });

Move this repeated code to a separate shared private method.

Comment 2

[Tom S. (please needinfo tschuster)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f9d56fbbdbd6

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f9d56fbbdbd6