Respect browser.urlbar.trimURLs

VERIFIED FIXED in Firefox 27

Status

()

defect
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
Firefox 27
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Posted patch trim-androidSplinter Review
Somebody on reddit was asking about this (http://www.reddit.com/r/firefox/comments/1osqyw/firefox_24_android_address_url_wonder_bar_we_they/) and it seemed to be quite easy to implement.
Attachment #819400 - Flags: review?(wjohnston)
Assignee: nobody → evilpies
Status: NEW → ASSIGNED
Comment on attachment 819400 [details] [diff] [review]
trim-android

Review of attachment 819400 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/BrowserToolbar.java
@@ +238,5 @@
>                  });
>              }
>  
>              @Override
> +            public void prefValue(String pref, boolean value) {

If you're not going to explicitly check the pref, lets at least add a comment to both of these methods about what pref they're handling.

@@ +249,5 @@
> +                    @Override
> +                    public void run() {
> +                        updateTitle();
> +                    }
> +                });

Move this repeated code to a separate shared private method.
Attachment #819400 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/f9d56fbbdbd6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.