928736 - NamespaceImports.h:41:7: warning: type attributes ignored after type is already defined

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[:Benjamin Peterson]

Attachment: ni-warn.patch

In file included from ../gc/Barrier.h:10:0,
                 from ../jsatom.h:14,
                 from ../vm/Runtime.h:19,
                 from ../jscntxt.h:15,
                 from ../builtin/TypeRepresentation.h:51,
                 from ../jscompartment.h:12,
                 from /home/benjamin/dev/mozilla/inbound/js/src/gc/Iteration.cpp:8:
../NamespaceImports.h:41:7: warning: type attributes ignored after type is already defined [-Wattributes]
../NamespaceImports.h:42:7: warning: type attributes ignored after type is already defined [-Wattributes]

Attached patch resolves this by not importing ContextOptionsRef. That seems fine to me, since people inside the engine should use cx->options().

Comment 1

[Jim Blandy :jimb]

I'd love for this to get fixed... I even have my own patch for it. But Benjamin's seems more focussed.

Note that Clang++ complains if the attributes are *not* present on forward declarations, so placing them only on the full declaration isn't an option.

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 819476 [details] [diff] [review]
ni-warn.patch

Yoink.  Thanks Benjamin!

Comment 3

[:Benjamin Peterson]

Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/17a6af9a1c58

Comment 4

[:Benjamin Peterson]

Fix for Clang from Waldo:

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fb5370a0a1e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/17a6af9a1c58
https://hg.mozilla.org/mozilla-central/rev/1fb5370a0a1e