928784 - [B2G][Helix][Camera][zhaodawei] In the preview, the camera does not focus continuously.

Status: RESOLVED DUPLICATE of bug 925192

(Firefox OS Graveyard :: Gaia::Camera, defect, P2)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; aff-kingsoft-ciba; Zune 4.7)

Steps to reproduce:

When you launch the camera APP in the android OS, you can see that the camera can focus continuously in the previewing.
The FFOS donot support this feature now.
But the camera device and camera driver have supportted it.

Comment 1

[lecky]

To implement this feature, it only need to set the focus mode to 'continuous-picture'.
When the focus mode is 'continuous-picture',the camera device will focus continuously itself. 
So I try to modify the camera APP.
Please see the attachment.

Comment 2

[lecky]

Attachment: 0001-DTS-DTS2013082710255.patch

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Lecky,

This continuous focus looks cool. You should create a pull request of it and set the review to David (:djf).

BTW, the comment "/* < DTS2013082710255 zhaodawei 20131009 BEGIN/END */" seems useless. We may change it as more understandable comment to tell why and how we deal with it.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

One more thing: may you confirm the power usage of this patch?? Does it consumes more power than before??

Comment 5

[lecky]

Hi John,

The comment "/* < DTS2013082710255 zhaodawei 20131009 BEGIN/END */" are our internal identification.
You can ignore them.
I will give the power data later.

Hi David,

Could you help to review the codes?

Comment 6

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

Hi Lecky,
   The following link will help you how to submit a patch to gaia.
   https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS/Platform/Gaia/Hacking#Submitting_a_patch

   And if you want someone give 'feedback' or 'review' for your patch, 
   you need to set 'feedback' or 'review' flag on your patch.

   thanks.

Comment 7

[lecky]

Hi Gary,

Thank you for your guidance. I will re-submit a patch.

Comment 8

[Wayne Chang [:wchang]]

Thanks for your help Gary and John, would you be so kind to help out Lecky here if he has more questions about contributing? 

Thanks for contributing Lecky!

As this is a feature request for v1.1/HD, I'll remove hd? on this as it should not block the release. but please continue your work on this bug! (And i'll assign it to you so it doesnt look like an orphan)

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Lecky,

I understand this comment is important to you. But that may be not significant to gaia. You may keep it in your branch but remove it from pull request to gaia/master.

(In reply to lecky from comment #5)
> Hi John,
> 
> The comment "/* < DTS2013082710255 zhaodawei 20131009 BEGIN/END */" are our
> internal identification.
> You can ignore them.
> I will give the power data later.
> 
> Hi David,
> 
> Could you help to review the codes?

Comment 10

[lecky]

Hi John,

I agree with you.
The feathure I added is only the requirement in our project.
I also think that it is not perfect for gaia/master. This feature need to add to the setting item of the camera APP in the future version. And it also need to implement the focus ring which can indicate the focus state real time.

The reason why I file this bug is that I want to confirm whether I can change like this in our branch.
And also we can discuss the detailed realization of the feature in this bug.

Comment 11

[lecky]

By the way, the power will increase an average of 20mA.

Comment 12

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 819536 [details] [diff] [review]
0001-DTS-DTS2013082710255.patch

I'm f-minus-ing this patch because the change in behaviour conflicts with the proposed user story in bug 925192.

Comment 13

[John Hu [:johnhu][:johu][:醬糊小弟]]

Mike,

Thanks for bring this bug. I never found this bug is created. Should we just make this one as duplicate of bug 925192?

Lecky, if you still want to work on this bug, how about move the patch to bug 925192?

Comment 14

[lecky]

OK,I will follow bug 925192.