Closed Bug 928801 Opened 11 years ago Closed 11 years ago

[wasabi][settings] Should use the term 'EVDO', 'CDMA' for CDMA network modes

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, firefox27 verified, b2g-v1.2 verified)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
firefox27 --- verified
b2g-v1.2 --- verified

People

(Reporter: arthurcc, Assigned: gasolin)

References

Details

Attachments

(1 file)

pull request redirect to github
181 bytes, text/html
arthurcc
: review+
Details
In bug 923088, we mapped the CDMA network modes to 2G/3G, which seems not reasonable. Should use 'CDMA only' and 'EVDO only' instead of '3G only' or '2G only'.
Fred, could you help on this? Thanks!
Flags: needinfo?(gasolin)
Blocks: 890823
Arthur, should it be 'CDMA'/'EVDO' or 'CDMA only'/'EVDO only' in this case?
Assignee: nobody → gasolin
Flags: needinfo?(gasolin)
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → Other
Now the network type displays: - "cdma/evdo": Automatic - "cdma": 2G only - "evdo": 3G only I'd like to suggest: - "cdma/evdo": Automatic - "cdma": CDMA - "evdo": EVDO
Attachment #819581 - Flags: review?(arthur.chen)
Comment on attachment 819581 [details] pull request redirect to github r=me, thanks.
Attachment #819581 - Flags: review?(arthur.chen) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/5874a4e65319a5ccd4d367303d2da819ec376475 thanks!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Enpei, please help to verify the master build after TPE CI generate the B2G.master.wasabi #121 build. Thank you.
Wasabi master branch has the fix now. Gaia: d6ce2a8514477edcec822b178715fc35ce42001c Gecko: c4665b79bd43dacdd9bc500e1b95be9bf6c370d2 BuildID 20131021234547 Version 27.0a1 Can we change this in 1.2 as well?
(In reply to Arthur Chen [:arthurcc] from comment #0) > In bug 923088, we mapped the CDMA network modes to 2G/3G, which seems not > reasonable. Should use 'CDMA only' and 'EVDO only' instead of '3G only' or > '2G only'. Plus it based since the updated string is more user friendly to reflect the current network mode
blocking-b2g: koi? → koi+
m-c verified.
Uplifted 5874a4e65319a5ccd4d367303d2da819ec376475 to: v1.2: 7a31a4c524f232fce22811569f2ef9337cb81fb8
status-b2g-v1.2: affected → fixed
Verified on v1.2 Wasabi. Gaia: b67568c07ccde602b43115efade3170234ac95a5 Gecko: ab2e9673cd90af3b7e8d18472e0373bdd6743daf BuildID 20131025031555 Version 26.0a2
Status: RESOLVED → VERIFIED
status-b2g-v1.2: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: