928825 - Large bookmark toast notification in landscape

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Landscape_Phone_Bookmark

Tested with:
Device: Samsung Galaxy Nexus
OS: Android 4.1.1

Steps to Reproduce:
1. In landscape mode go to google.com
2. Tap Menu -> Bookmark

Expected result:
- A small toast notification appears "Bookmark added" (like in portrait mode)

Actual Result:
- A large toast notification appears "Bookmark added"
Please see the attachment

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

I thought we just fixed a bug like this, but for tablets? I wonder if the screenshot *is* the expected result now that we made the tablet fix.

Comment 2

[Aaron Train [:aaronmt]]

Shilpan fixed this in bug 899560. So if it's not fixed now, this regressed.

Comment 3

[Aaron Train [:aaronmt]]

The screenshot in bug 899560 shows the UI after his patch (https://bug899560.bugzilla.mozilla.org/attachment.cgi?id=791405). So the screenshot here does not match, as such, this is a regression than. Teodora, please find a window.

Comment 4

[Teodora Vermesan (:TeoVermesan)]

I don't think this is a regression. It is reproducible on all branches.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

Thank you for investigating. Maybe a good mentor bug?

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.