Closed Bug 928827 Opened 6 years ago Closed 6 years ago

SelectStyleSheet does not move the cursor to proper line/column if any editor is already loaded

Categories

(DevTools :: Style Editor, defect)

x86_64
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: Optimizer, Assigned: Optimizer)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch v0.1 (obsolete) — Splinter Review
since the object _styleSheetToSelect is non null if *any* stylesheet in style editor was opened earlier, the selectStyleSheet method exits early without doing anything but updating the to be selected sheet. This fails when the same stylesheet was opened at the time of the call as it does not update the cursor to the newly asked positions.
Attachment #819599 - Flags: review?(mihai.sucan)
Attachment #819599 - Flags: review?(mihai.sucan) → review+
Attached patch patch v0.1Splinter Review
Patch to land. Just added a commit message.
Assignee: nobody → scrapmachines
Attachment #819599 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #820166 - Flags: review+
Keywords: checkin-needed
Patch looks good. Thank you Girish and Paul.
Pushed this along with a bunch of other checkin-neededs to try:
https://tbpl.mozilla.org/?tree=Try&rev=2c426f843d08
https://hg.mozilla.org/mozilla-central/rev/5ba7172333e2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.