SelectStyleSheet does not move the cursor to proper line/column if any editor is already loaded

RESOLVED FIXED in Firefox 27

Status

RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: Optimizer, Assigned: Optimizer)

Tracking

unspecified
Firefox 27
x86_64
Windows 7

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 819599 [details] [diff] [review]
patch v0.1

since the object _styleSheetToSelect is non null if *any* stylesheet in style editor was opened earlier, the selectStyleSheet method exits early without doing anything but updating the to be selected sheet. This fails when the same stylesheet was opened at the time of the call as it does not update the cursor to the newly asked positions.
Attachment #819599 - Flags: review?(mihai.sucan)

Updated

5 years ago
Attachment #819599 - Flags: review?(mihai.sucan) → review+
(Assignee)

Comment 1

5 years ago
Created attachment 820166 [details] [diff] [review]
patch v0.1

Patch to land. Just added a commit message.
Assignee: nobody → scrapmachines
Attachment #819599 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #820166 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Patch looks good. Thank you Girish and Paul.

Comment 3

5 years ago
Pushed this along with a bunch of other checkin-neededs to try:
https://tbpl.mozilla.org/?tree=Try&rev=2c426f843d08

Comment 4

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/5ba7172333e2
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5ba7172333e2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.