928953 - WebIDL headers should include the file for enums

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Zbarsky (:dzbarsky)]

Attachment: webidl-patch

And a typo fix along the way.  Although clearly that branch was never being hit, so maybe we don't actually need it?

Comment 1

[David Zbarsky (:dzbarsky)]

We need this to handle the following WebIDL (because OwningSpacingModeOrDouble needs to call sizeof on SpacingMode):

enum SpacingMode { "distribute", "align" };

typedef (SpacingMode or double) EasingTimesInput;

interface Timing { 
  ...
  EasingTimesInput getEasingTimes();
};

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 819750 [details] [diff] [review]
webidl-patch

UnionTypes.h shouldn't need PrimitiveConversions.h, yeah.  Just nuke that branch.

Testing for IDLWrapperType is over-eager, I think...  It'll over-include for interfaces, I think.  Why not just test for f.isEnum() if that's what we want?

Comment 3

[David Zbarsky (:dzbarsky)]

Attachment: patch

Yeah, f.isEnum() is enough.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8350452 [details] [diff] [review]
patch

I swear someone else ran into this a few days ago...

Anyway, r=me

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42c5d19e4f52

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/42c5d19e4f52