Closed Bug 929024 Opened 6 years ago Closed 6 years ago

ASan symbols broken in mochitest automation

Categories

(Testing :: Mochitest, defect, critical)

x86_64
Linux
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED FIXED
mozilla27

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want)

Attachments

(1 file)

The mochitest refactoring in bug 746243 did not port the code landed in bug 917242 to symbolize ASan traces. I will try to come up with a patch to solve this to unblock the sheriffs on this.
Simple fix, port the missing code from automation.py.in. Tested locally and confirmed to be working.
Attachment #819860 - Flags: review?(ted)
Comment on attachment 819860 [details] [diff] [review]
asan-mochitest-symbols.patch

Review of attachment 819860 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, sorry for missing this in my review of the refactoring patch.
Attachment #819860 - Flags: review?(ted) → review+
Thanks for the quick review :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/55d36871fbd8
Status: NEW → ASSIGNED
\o/

Thank you Christian :-D
https://hg.mozilla.org/mozilla-central/rev/55d36871fbd8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.