929051 - Add comment explaining `+ 1` usage in SearchEngineRow.updateFromSearchEngine

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We have a pool of views that we re-use for search engine suggestions in SearchEngineRow. However, we start reusing these views at an offset of + 1 [1] and this is unexplained. A discussion on bug 925517 comment 14 explained that this is used to offset one bubble for what the user is currently typing.

We should add a comment explaining this behavior.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/SearchEngineRow.java?rev=e256831552b9#182

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.