Closed Bug 929468 Opened 7 years ago Closed 7 years ago

test_sms_contact, test_call_contact, test_dialer_add_contact are not using mock_contact properly

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: zcampbell)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
Bebe
: review-
moz.teodosia
: review+
Details | Review
Fix them
Attached file github pr
Attachment #820332 - Flags: review?(alin.trif)
Summary: test_sms_contact, test_call_contact are not using mock_contact properly → test_sms_contact, test_call_contact, test_dialer_add_contact are not using mock_contact properly
Comment on attachment 820332 [details] [review]
github pr

https://github.com/mozilla-b2g/gaia/pull/13008
r+
Attachment #820332 - Flags: review?(florin.strugariu)
Attachment #820332 - Flags: review?(alin.trif)
Attachment #820332 - Flags: review+
Comment on attachment 820332 [details] [review]
github pr

Sorry guys I missed a file - can you re-r?
Attachment #820332 - Flags: review+ → review?(alin.trif)
Attachment #820332 - Flags: review-
Attachment #820332 - Flags: review?(florin.strugariu) → review-
Attachment #820332 - Flags: review- → review+
https://github.com/mozilla-b2g/gaia/commit/6d23c2f9153d0e1d17679cb9c317e75a0ee9a490
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #820332 - Flags: review?(trifandreialin)
You need to log in before you can comment on or make changes to this bug.