Closed Bug 929548 Opened 6 years ago Closed 6 years ago

Australis: LWT tab middle background disappears when dragging a tab

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: Gijs, Assigned: MattN)

References

Details

(Keywords: regression, Whiteboard: [Australis:P2][Australis:M9])

Attachments

(1 file, 1 obsolete file)

On OS X (hidpi):

STR
1. Open Fx
2. Use a lwtheme
3. Start dragging a tab

AR:
4. The middle of the tab whites out completely.

:-(
I'll see if I can figure this one out.
Assignee: nobody → mconley
Attached patch Patch v1 (obsolete) — Splinter Review
Does this look right, Matt? Or am I missing something?

And how come you weren't experiencing this bug?
Attachment #820525 - Flags: review?(mnoorenberghe+bmo)
(In reply to Mike Conley (:mconley) from comment #2)
> Does this look right, Matt? Or am I missing something?

Sorry for the delay, I'll get to this tomorrow. I looked at this last week and wanted to look closer.

> And how come you weren't experiencing this bug?

When we were discussing this I thought I would have noticed it while working on bug 921038 but I forgot that it required dragging so it's not so in-your-face.
Status: NEW → ASSIGNED
Hardware: x86 → All
We probably shouldn't be shipping this.
Whiteboard: [Australis:P4] → [Australis:P2]
Comment on attachment 820525 [details] [diff] [review]
Patch v1

Review of attachment 820525 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!
Attachment #820525 - Flags: review?(mnoorenberghe+bmo) → review+
This is a regression from https://hg.mozilla.org/projects/ux/rev/14a05f3555df#l4.33 wherein I deleted a line which does the same as what you're adding. I'll look if we can simply put that line back instead.
Blocks: 915521
No longer blocks: australis-tabs
Any getting that working, Matt?
Flags: needinfo?(mnoorenberghe+bmo)
Sorry, I've been thinking about this almost everyday but it keeps slipping. I'll do it today.
Attached patch Backout v.1Splinter Review
Backout the background-image removal from
https://hg.mozilla.org/projects/ux/rev/14a05f3555df#l4.33

This ensures the default LWT tab-background-middle texture is the LWT variant "fgTabTextureLWT".
Assignee: mconley → MattN+bmo
Attachment #820525 - Attachment is obsolete: true
Attachment #832866 - Flags: review?(gijskruitbosch+bugs)
Flags: needinfo?(MattN+bmo)
Comment on attachment 832866 [details] [diff] [review]
Backout v.1

Review of attachment 832866 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/tabs.inc.css
@@ -203,2 @@
>    /* Don't stretch the LWT header images */
>    background-size: auto 100%, auto 100%, auto auto;

This seems to define 3 sizes, but there are now 2 background images. Can we get rid of the last 'auto auto' or am I missing something? If I'm missing something, please put in a comment, otherwise please remove the last item in the list.
Attachment #832866 - Flags: review?(gijskruitbosch+bugs) → review+
Thanks!

https://hg.mozilla.org/projects/ux/rev/c39317fbc7a9

(In reply to :Gijs Kruitbosch from comment #11)
> Comment on attachment 832866 [details] [diff] [review]
> ::: browser/themes/shared/tabs.inc.css
> @@ -203,2 @@
> >    /* Don't stretch the LWT header images */
> >    background-size: auto 100%, auto 100%, auto auto;
> 
> This seems to define 3 sizes, but there are now 2 background images. Can we
> get rid of the last 'auto auto' or am I missing something? If I'm missing
> something, please put in a comment, otherwise please remove the last item in
> the list.

The third gets added in browser-lightweightTheme.css at run-time. I added a comment indicate the header image will be substituted there and also update the comment in the heading of the selected tab LWT to point to browser-lightweightTheme.css
Whiteboard: [Australis:P2] → [Australis:P2][Australis:M9][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/c39317fbc7a9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P2][Australis:M9][fixed-in-ux] → [Australis:P2][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.