929548 - Australis: LWT tab middle background disappears when dragging a tab

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

On OS X (hidpi):

STR
1. Open Fx
2. Use a lwtheme
3. Start dragging a tab

AR:
4. The middle of the tab whites out completely.

:-(

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I'll see if I can figure this one out.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Does this look right, Matt? Or am I missing something?

And how come you weren't experiencing this bug?

Comment 3

[Matthew N. [:MattN]]

(In reply to Mike Conley (:mconley) from comment #2)
> Does this look right, Matt? Or am I missing something?

Sorry for the delay, I'll get to this tomorrow. I looked at this last week and wanted to look closer.

> And how come you weren't experiencing this bug?

When we were discussing this I thought I would have noticed it while working on bug 921038 but I forgot that it required dragging so it's not so in-your-face.

Comment 4

[:Gijs (he/him)]

We probably shouldn't be shipping this.

Comment 5

[:Gijs (he/him)]

Comment on attachment 820525 [details] [diff] [review]
Patch v1

Review of attachment 820525 [details] [diff] [review]:
-----------------------------------------------------------------

Ship it!

Comment 6

[Matthew N. [:MattN]]

This is a regression from https://hg.mozilla.org/projects/ux/rev/14a05f3555df#l4.33 wherein I deleted a line which does the same as what you're adding. I'll look if we can simply put that line back instead.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Any getting that working, Matt?

Comment 8

[Mike Conley (:mconley) (:⚙️)]

s/Any/Any luck

Comment 9

[Matthew N. [:MattN]]

Sorry, I've been thinking about this almost everyday but it keeps slipping. I'll do it today.

Comment 10

[Matthew N. [:MattN]]

Attachment: Backout v.1

Backout the background-image removal from
https://hg.mozilla.org/projects/ux/rev/14a05f3555df#l4.33

This ensures the default LWT tab-background-middle texture is the LWT variant "fgTabTextureLWT".

Comment 11

[:Gijs (he/him)]

Comment on attachment 832866 [details] [diff] [review]
Backout v.1

Review of attachment 832866 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/tabs.inc.css
@@ -203,2 @@
>    /* Don't stretch the LWT header images */
>    background-size: auto 100%, auto 100%, auto auto;

This seems to define 3 sizes, but there are now 2 background images. Can we get rid of the last 'auto auto' or am I missing something? If I'm missing something, please put in a comment, otherwise please remove the last item in the list.

Comment 12

[Matthew N. [:MattN]]

Thanks!

https://hg.mozilla.org/projects/ux/rev/c39317fbc7a9

(In reply to :Gijs Kruitbosch from comment #11)
> Comment on attachment 832866 [details] [diff] [review]
> ::: browser/themes/shared/tabs.inc.css
> @@ -203,2 @@
> >    /* Don't stretch the LWT header images */
> >    background-size: auto 100%, auto 100%, auto auto;
> 
> This seems to define 3 sizes, but there are now 2 background images. Can we
> get rid of the last 'auto auto' or am I missing something? If I'm missing
> something, please put in a comment, otherwise please remove the last item in
> the list.

The third gets added in browser-lightweightTheme.css at run-time. I added a comment indicate the header image will be substituted there and also update the comment in the heading of the selected tab LWT to point to browser-lightweightTheme.css

Comment 13

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/c39317fbc7a9