Please schedule a mozharness run that includes scripts/gaia_integration.py on cedar

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gaye, Assigned: jgriffin)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

I would like to stage a build that includes the new https://github.com/mozilla/build-mozharness/blob/master/scripts/gaia_integration.py script on the cedar staging branch.

Comment 1

5 years ago
Moving it to General Automation so it can be triaged.
Component: Buildduty → General Automation
QA Contact: armenzg → catlee
(Assignee)

Comment 2

5 years ago
(In reply to Gareth Aye [:gaye] from comment #0)
> I would like to stage a build that includes the new
> https://github.com/mozilla/build-mozharness/blob/master/scripts/
> gaia_integration.py script on the cedar staging branch.

It looks like we need a config file for this still; Gareth, can you tell us what parameters you usually pass to this script, if any?
Flags: needinfo?(gaye)
That seems perfect. I have an extra 'npm_registry' that I define here http://hg.mozilla.org/build/mozharness/file/7bf07524c01b/mozharness/base/gaia_test.py, but it defaults to what I want. Can we reuse the gaia_unit_production_config.py?
Flags: needinfo?(gaye)
(Assignee)

Comment 5

5 years ago
That should work.
Assignee: nobody → jgriffin
(Assignee)

Comment 6

5 years ago
Created attachment 821296 [details] [diff] [review]
Schedule gaia-integration tests on cedar,

This schedules the tests on opt linux32/64 b2g desktop builds, cedar-only.
Attachment #821296 - Flags: review?(aki)
+1

Comment 8

5 years ago
Comment on attachment 821296 [details] [diff] [review]
Schedule gaia-integration tests on cedar,

Thanks!
Attachment #821296 - Flags: review?(aki) → review+
(Assignee)

Comment 9

5 years ago
Comment on attachment 821296 [details] [diff] [review]
Schedule gaia-integration tests on cedar,

Review of attachment 821296 [details] [diff] [review]:
-----------------------------------------------------------------

https://hg.mozilla.org/build/buildbot-configs/rev/f6abc48f2696

Gareth, this won't be live until the next buildbot reconfig, either Thursday or Monday.
Attachment #821296 - Flags: checked-in+
Jonathon - Can you needinfo me here or ping me on irc when that happens? When it comes to buildbot http://i1.kym-cdn.com/photos/images/newsfeed/000/234/786/bf7.gif
Flags: needinfo?(jgriffin)
s/Jonathon/Jonathan/ ::facepalm:: sorry!
in production
(Assignee)

Comment 13

5 years ago
This is live on cedar now, but failing due to a bug in the mozharness script:

11:42:09     INFO - #####
11:42:09     INFO - ##### Running run-tests step.
11:42:09     INFO - #####
11:42:09     INFO - Running pre-action listener: _resource_record_pre_action
11:42:09     INFO - Running main action method: run_tests
11:42:09     INFO - Running command: ['make test-integration'] in /builds/slave/test/gaia
11:42:09     INFO - Copy/paste: "make test-integration"
11:42:09     INFO - Using env: {'MOCHA_REPORTER': 'mocha-tbpl-reporter',
11:42:09     INFO -  'NPM_REGISTRY': 'http://npm-mirror.pub.build.mozilla.org'}
11:42:09    ERROR - caught OS error 2: No such file or directory while running ['make test-integration']

At a glance, I'd say that the command needs to be specified as ['make', 'test-integration'].
Flags: needinfo?(jgriffin) → needinfo?(gaye)
Created attachment 822773 [details] [diff] [review]
Patch for gaia_integration.py make issue

Jonathan or Aki,

Hey if either of you are around today would you mind reviewing and pushing my patch for me? I think it was just an issue with passing "make test-integration" to script#query_exe like Jonathan mentioned.
Attachment #822773 - Flags: review?(jgriffin)
Attachment #822773 - Flags: review?(aki)
Flags: needinfo?(gaye)
(Assignee)

Comment 16

5 years ago
Comment on attachment 822773 [details] [diff] [review]
Patch for gaia_integration.py make issue

Review of attachment 822773 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the change below.

::: scripts/gaia_integration.py
@@ +31,5 @@
>          # `make test-integration \
>          #      MOCHA_REPORTER=mocha-tbpl-reporter \
>          #      NPM_REGISTRY=http://npm-mirror.pub.build.mozilla.org`
> +        make = self.query_exe('make', return_type='list')
> +        cmd = [make, 'test-integration']

Since the return_type of make is 'list', what you want is probably something like:

cmd = make + ['test-integration']
Attachment #822773 - Flags: review?(jgriffin) → review+
(Assignee)

Updated

5 years ago
Attachment #822773 - Flags: review?(aki)
Created attachment 822890 [details] [diff] [review]
Updated patch to fix make command

Hi Jonathan,

Thanks for taking a look. Obviously my python chops are not all the way there yet :). I changed the return_type to string. Would you mind pushing this to hg.mozilla.org/build/mozharness for me? I filed a bug for commit access, but I think the message hasn't gotten to the hg servers yet.
Attachment #822890 - Flags: checked-in?
Flags: needinfo?(jgriffin)
(Assignee)

Comment 18

5 years ago
Comment on attachment 822890 [details] [diff] [review]
Updated patch to fix make command

https://hg.mozilla.org/build/mozharness/rev/00db6f60cf7f
Attachment #822890 - Flags: review+
Attachment #822890 - Flags: checked-in?
Attachment #822890 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Flags: needinfo?(jgriffin)
Thanks!
(Assignee)

Comment 20

5 years ago
These are running; separate bugs will be used to address harness failures.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(In reply to Gareth Aye [:gaye] from comment #17)
> Thanks for taking a look. Obviously my python chops are not all the way
> there yet :). I changed the return_type to string.

It's probably fine here, but it's best practice to match the return_type to the way you'll use it.

If self.query_exe('make', return_type='string') returns 'python path/to/pymake.py', then the command ['python path/to/pymake.py', 'test-integration'] will break.  Since this isn't going to run on windows (afaik), the chance of a 'make' of more than one "word" is slim, so this is probably fine.

Comment 22

5 years ago
In production
I saw these up before, but I don't see them anymore on https://tbpl.mozilla.org/?tree=Cedar. Were they turned off?
Status: RESOLVED → REOPENED
Flags: needinfo?(jgriffin)
Resolution: FIXED → ---
(Assignee)

Comment 24

5 years ago
No, they're just hidden (since they're broken); use https://tbpl.mozilla.org/?tree=Cedar&showall=1 to see.
Flags: needinfo?(jgriffin)
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Ah my bad. Thanks!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Component: General Automation → Mozharness
You need to log in before you can comment on or make changes to this bug.