929759 - Set up email script for commbadge

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Christopher Van Wiemeersch [:cvan]]

11:22 < jason> if you send a email to '*@marketplace-dev.allizom.org' it will hit the postfix server
11:22 < jason> and it will post to the marketplace api
11:22 < jason> we can restrict to addresses that start with reply

https://github.com/mozilla/zamboni/blob/master/sites/dev/settings_mkt.py#L201-L205

Comment 1

[Kevin Ngo [:ngoke]]

What's the email script supposed to do?

Comment 2

[Wil Clouser [:clouserw]]

1) Verify it's an email
2) Verify the email is valid for the conversation it's claiming to be in
3) Parse the email and extract the new comments
4) Put the new comments into the database from the author it claims to be from
5) Email the other people in the conversation with the new comments

Comment 3

[Kevin Ngo [:ngoke]]

I'm not sure if this can be QA'ed on dev with SEND_REAL_MAIL turned off.

https://github.com/mozilla/zamboni/pull/1803

STR:

1. As a reviewer, post a note to Commbadge.
2. As developer, receive automatic email from Commbadge.
3. As developer, reply to email.

Expected:

In Commbadge, the email reply should become a note.

Actual:

It's fuzzy since emails are turned off on -dev. But before the email reply functionality wasn't completely hooked up.

Comment 4

[Iulian Timis]

I tried verifying this bug on -dev using the STR, but I have not received any e-mail. Should we wait until this is pushed to stage? Will it work then? Thank you!

Comment 5

[Victor Carciu]

Kevin, can you please help us with SEND_REAL_MAIL in order to test here?

Comment 6

[Wil Clouser [:clouserw]]

we can't flip that on -dev, it'll send all kinds of email.  This either needs to be tested on stage or manually (likely by ops).

Comment 7

[Kevin Ngo [:ngoke]]

Commbadge is now on on stage, so it should send emails now.

Comment 8

[Iulian Timis]

I'm still not receiving any emails on MP-stage after a reviewer approves or posts a reply in Comm Dash for an app that I have submitted. https://marketplace.allizom.org/app/test-app-macarena/

Comment 9

[Wil Clouser [:clouserw]]

postfix scripts aren't on stage yet.  Jason will have it set up by the end of the week. Closing, but won't be verifiable until next week.

Comment 10

[Kevin Ngo [:ngoke]]

Is this verifiable now?

Comment 11

[Iulian Timis]

Verified as fixed in https://marketplace-dev.allizom.org/comm/ and https://marketplace-dev.allizom.org/admin/mail in FF31 (Win 7).
Attaching postfix screenshot.
Closing bug.

Comment 12

[Iulian Timis]

Attachment: postfix_commdash_email_notif.png

Comment 13

[Iulian Timis]

Verified also that the newly added replies in comm dash are sent through email to all the other people in the conversation thread.