929792 - [B2G][1.2][l10n][Settings]All Languages: "Built-In Keyboard" is displayed in English in the Keyboards menu.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[J Zimbrick]

Attachment: Sample screen displaying issue with device set to Croatian.

Description:
"Built-In Keyboard" is shown in English in the Keyboards menu no matter what language the device is currently set to.

Repro Steps:
1. Update Buri to 1.2 com build 20131022004000.
2. Set device to any language other than English.
3. Open the Settings app.
4. Scroll down to Keyboards menu under the Personalization section and select it.
5. Observe that "Built-in Keyboard" is displayed in English no matter what language the device is set to.

Actual:
"Built-In Keyboard" is displayed in English no matter what language the device is set to.

Expected:
"Built-In Keyboard" is localised to whichever language the device is set to.

Environmental Variables:
Device: Buri v1.2 Commercial RIL
BuildID: 20131022004000
Gaia: 00d5964eabf95a6a8a632420dfa36fc76dcbc9b7
Gecko: 7453a764f9a9
Version: 26.0a2
Base Image: 20131015

Repro frequency: 100%

See attached: Screenshot

Comment 1

[J Zimbrick]

After further research, some languages do appear to have "Built-In Keyboard" properly localised:

Bulgarian, Hindi, Turkish, Spanish, Macedonian, Portuguese, Romanian, Traditional and Simplified Chinese.

These languages are affected by this issue:

Arabic (Displays as "Keyboard"), Catalan, Czech, German, Greek, French, Croatian, Hungarian, Italian, Dutch, Polish, Russian, Slovak, Serbian and Cyrillic Serbian (Display as "Keyboard")

If necessary I can file individual bugs for each language.

Comment 3

[Stefan Plewako [:stef]]

dupe of 927855?

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

No, bug 927855 is part of this problem but related to the manifest file. This one is more about the UI.

Comment 5

[David Flanagan [:djf]]

We block for unlocalized strings, don't we?

Comment 6

[Chris Kreinbring [:CKreinbring]]

Also seen if the user taps the Selected Keyboards field and observes the options.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

One of the manifest.webapp localization dup?

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: link to https://github.com/mozilla-b2g/gaia/pull/13173

Evelyn, could you help review the change? Thanks.

Comment 9

[Evelyn Hung]

Comment on attachment 823931 [details]
link to https://github.com/mozilla-b2g/gaia/pull/13173

r=me, looks good. Thanks!

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks!

master: cfe7247433555a81d9347dbc0c3e258a7dbcbadc

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted cfe7247433555a81d9347dbc0c3e258a7dbcbadc to:
v1.2: c8902d31d9bf219739c1d31a8a2be48761470422