929817 - [B2G] [1.2] [l10n] [Contacts]: Current location header from Facebook contacts is shown in English on every language

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of untranslated text

Description:
The text of the header for a Facebook contact's current location is shown in English regardless of the device's set language.

Repro Steps:
1) Update Buri to Build ID: 20131022004000
2) Set the device language to any language except English.
3) Restart the device.
4) Launch the Contacts app.
5) Tap the Settings gear icon then tap the Sync Friends switch.
6) When the Facebook login screen loads, enter a valid username and password then tap Log In.
7) Once the contacts list loads, select a contact with a current location in its profile then tap Update.
8) Return to the contact list and open the Facebook contact's details.
9) Observe the appearance of the header for the contact's current location.

Actual:
The text is shown in English.

Expected:
The entire text is shown in the chosen language.

Environmental Variables
Device: Buri 1.2 Commercial RIL
Build ID: 20131022004000
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/7453a764f9a9
Gaia: 00d5964eabf95a6a8a632420dfa36fc76dcbc9b7
Platform Version: 26.0a2
RIL Version: 01.02.00.019.082

Notes:
Repro frequency: 100%
See attached screenshot

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch v1.0

Comment 2

[Jose Manuel Cantera]

Comment on attachment 821040 [details]
patch v1.0

incomplete solution

Comment 3

[ayman maat :maat]

It would seem that the core of the problem is that we do not have an address type 'current' which facebook does. Therefore I think a quick pragmatic and low risk solution would be to add a 'current' type to the list of address types. 

ni? me if that does not work for you jose, or you consider an improved alternative solution

Comment 4

[Jose Manuel Cantera]

Attachment: 16450.html

fixed as per the UX recommendations

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8378286 [details]
16450.html

Thanks,

merge once travis is green and the tree is open!

Comment 6

[Jose Manuel Cantera]

Hi Fabrice,

This is a pretty low risk patch concerning a localization issue. Can we land this in master in order to have it for v1.4?

thanks!

Comment 7

[[:fabrice] Fabrice Desré]

Yes, you can land - just have good test coverage, and don't break anything.

Comment 8

[Jose Manuel Cantera]

landed in master:

It is only a localization issue. no tests needed

https://github.com/mozilla-b2g/gaia/commit/e6f80a4770f576c8b517ff85e33fea0e8e914750